StudyDistractor/sdp

View on GitHub
app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt

Summary

Maintainability
B
5 hrs
Test Coverage
A
100%

Avoid too many return statements within this method.
Open

        return _createUserModel.createUser(UserData(
            firstname = uiState.value.firstname,
            lastname = uiState.value.lastname,
            phone = uiState.value.phoneNumber,
            birthday = timestamp,

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            if (!checkPhoneFormat(uiState.value.phoneNumber)) {
                return Tasks.forException(Exception("phoneNumber is invalid"))
            }
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 114..116
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 118..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            if (!checkNameFormat(uiState.value.firstname)) {
                return Tasks.forException(Exception("firstname is invalid"))
            }
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 118..120
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 122..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            if (!checkNameFormat(uiState.value.lastname)) {
                return Tasks.forException(Exception("lastname is invalid"))
            }
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 114..116
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 122..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

        fun updateFirstname(firstname: String) {
            _uiState.update { it.copy(firstname = firstname) }
        }
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 100..102
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 104..106
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 108..110
    app/src/main/java/com/github/studydistractor/sdp/distractionStat/DistractionStatViewModel.kt on lines 15..19
    app/src/main/java/com/github/studydistractor/sdp/distractionStat/DistractionStatViewModel.kt on lines 21..25
    app/src/main/java/com/github/studydistractor/sdp/distractionStat/DistractionStatViewModel.kt on lines 27..31
    app/src/main/java/com/github/studydistractor/sdp/eventChat/EventChatViewModel.kt on lines 34..42
    app/src/main/java/com/github/studydistractor/sdp/friends/FriendsViewModel.kt on lines 36..38
    app/src/main/java/com/github/studydistractor/sdp/register/RegisterViewModel.kt on lines 17..19
    app/src/main/java/com/github/studydistractor/sdp/register/RegisterViewModel.kt on lines 21..23
    app/src/main/java/com/github/studydistractor/sdp/register/RegisterViewModel.kt on lines 25..27

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

        fun updateLastname(lastname: String) {
            _uiState.update { it.copy(lastname = lastname) }
        }
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 96..98
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 104..106
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 108..110
    app/src/main/java/com/github/studydistractor/sdp/distractionStat/DistractionStatViewModel.kt on lines 15..19
    app/src/main/java/com/github/studydistractor/sdp/distractionStat/DistractionStatViewModel.kt on lines 21..25
    app/src/main/java/com/github/studydistractor/sdp/distractionStat/DistractionStatViewModel.kt on lines 27..31
    app/src/main/java/com/github/studydistractor/sdp/eventChat/EventChatViewModel.kt on lines 34..42
    app/src/main/java/com/github/studydistractor/sdp/friends/FriendsViewModel.kt on lines 36..38
    app/src/main/java/com/github/studydistractor/sdp/register/RegisterViewModel.kt on lines 17..19
    app/src/main/java/com/github/studydistractor/sdp/register/RegisterViewModel.kt on lines 21..23
    app/src/main/java/com/github/studydistractor/sdp/register/RegisterViewModel.kt on lines 25..27

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

        fun updatePhoneNumber(phoneNumber: String) {
            _uiState.update { it.copy(phoneNumber = phoneNumber) }
        }
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 96..98
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 100..102
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 108..110
    app/src/main/java/com/github/studydistractor/sdp/distractionStat/DistractionStatViewModel.kt on lines 15..19
    app/src/main/java/com/github/studydistractor/sdp/distractionStat/DistractionStatViewModel.kt on lines 21..25
    app/src/main/java/com/github/studydistractor/sdp/distractionStat/DistractionStatViewModel.kt on lines 27..31
    app/src/main/java/com/github/studydistractor/sdp/eventChat/EventChatViewModel.kt on lines 34..42
    app/src/main/java/com/github/studydistractor/sdp/friends/FriendsViewModel.kt on lines 36..38
    app/src/main/java/com/github/studydistractor/sdp/register/RegisterViewModel.kt on lines 17..19
    app/src/main/java/com/github/studydistractor/sdp/register/RegisterViewModel.kt on lines 21..23
    app/src/main/java/com/github/studydistractor/sdp/register/RegisterViewModel.kt on lines 25..27

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

        fun updateDateText(dateText: String) {
            _uiState.update { it.copy(dateText = dateText) }
        }
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 96..98
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 100..102
    app/src/main/java/com/github/studydistractor/sdp/createUser/CreateUserViewModel.kt on lines 104..106
    app/src/main/java/com/github/studydistractor/sdp/distractionStat/DistractionStatViewModel.kt on lines 15..19
    app/src/main/java/com/github/studydistractor/sdp/distractionStat/DistractionStatViewModel.kt on lines 21..25
    app/src/main/java/com/github/studydistractor/sdp/distractionStat/DistractionStatViewModel.kt on lines 27..31
    app/src/main/java/com/github/studydistractor/sdp/eventChat/EventChatViewModel.kt on lines 34..42
    app/src/main/java/com/github/studydistractor/sdp/friends/FriendsViewModel.kt on lines 36..38
    app/src/main/java/com/github/studydistractor/sdp/register/RegisterViewModel.kt on lines 17..19
    app/src/main/java/com/github/studydistractor/sdp/register/RegisterViewModel.kt on lines 21..23
    app/src/main/java/com/github/studydistractor/sdp/register/RegisterViewModel.kt on lines 25..27

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status