Sign upLogin

StudyDistractor/sdp

View on GitHub
Star

Showing 42 of 43 total issues

Method postDislike has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

    override fun postDislike(did: String) : Task<Void>{
        val uid = auth.uid ?: return Tasks.forException(Exception("Not login"))
        return db.getReference(pathLikes).child(did).child(uid).get().continueWithTask{
                j ->
            if(j.isSuccessful && j.result.value == uid){
Severity: Minor
Found in app/src/main/java/com/github/studydistractor/sdp/distractionStat/DistractionStatServiceFirebase.kt - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method postLike has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

    override fun postLike(did: String) : Task<Void> {
        val uid = auth.uid ?: return Tasks.forException(Exception("Not login"))
        return db.getReference(pathDislikes).child(did).child(uid).get().continueWithTask{
                j ->
                    if(j.isSuccessful && j.result.value == uid){
Severity: Minor
Found in app/src/main/java/com/github/studydistractor/sdp/distractionStat/DistractionStatServiceFirebase.kt - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language