app/controllers/api/pages_controller.rb
Method total_donations
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def total_donations
@page = Page.find(params[:page_id])
if @page.campaign.blank?
amount = @page.total_donations
Method all_params
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def all_params
# this method flattens a lot of nested data from one object per form element
# to one object per entity (page, share variant, etc) to modify
#
# this is pretty janky but it's the best I can do moving quickly
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"