Sign upLogin

SumOfUs/Champaign

View on GitHub
Star
app/models/payment/braintree.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method build has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def self.build(bt_result, page_id, member_id, existing_customer, save_customer = true, store_in_vault = false)
Severity: Minor
Found in app/models/payment/braintree.rb - About 45 mins to fix

    Method write_subscription has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def write_subscription(payment_method_id, customer_id, subscription_result, page_id, action_id, currency)
    Severity: Minor
    Found in app/models/payment/braintree.rb - About 45 mins to fix

      Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def initialize(bt_customer, bt_payment_method, member_id, existing_customer, store_in_vault)
      Severity: Minor
      Found in app/models/payment/braintree.rb - About 35 mins to fix

        Method write_transaction has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def write_transaction(bt_result, page_id, member_id, existing_customer, save_customer = true, store_in_vault: false)
        Severity: Minor
        Found in app/models/payment/braintree.rb - About 35 mins to fix

          Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def initialize(bt_result, page_id, member_id, existing_customer, save_customer = true, store_in_vault: false)
          Severity: Minor
          Found in app/models/payment/braintree.rb - About 35 mins to fix

            Method build has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def build
      return unless transaction.present?

      create_customer
      create_payment_method
            Severity: Minor
            Found in app/models/payment/braintree.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status