Sign upLogin

SungardAS/condensation

View on GitHub
Star

Showing 39 of 39 total issues

Function buildHelper has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function buildHelper(particleName, options) {

  var opts = _.merge({
    wrapLogicalId: true
  },options);
Severity: Minor
Found in lib/condensation/template-helpers/sections/_buildHelper.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function condense has 111 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Condensation.prototype.condense = function condense() {
  var self = this;
  var options = this.options;
  var gulp = this.gulp;
Severity: Major
Found in lib/condensation/index.js - About 4 hrs to fix

    Function buildHelper has 106 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function buildHelper(particleName, options) {

  var opts = _.merge({
    wrapLogicalId: true
  },options);
    Severity: Major
    Found in lib/condensation/template-helpers/sections/_buildHelper.js - About 4 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      jsdoc2md.render({
  files: [
    'lib/handlebars-helpers/*'
  ],
  partial: [
      Severity: Major
      Found in bin/buildDocs.js and 1 other location - About 4 hrs to fix
      bin/buildDocs.js on lines 5..19

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 119.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      jsdoc2md.render({
  files: ['lib/condensation/template-helpers/functions/*.js'],
  partial: [
    path.join(__dirname,"..","jsdoc2md","templates","sig-name.hbs")
  ],
      Severity: Major
      Found in bin/buildDocs.js and 1 other location - About 4 hrs to fix
      bin/buildDocs.js on lines 67..83

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 119.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function exports has 104 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(s3opts,distPath,awsS3) {
  var self = this;

  var templateData = {};
  var urlString = [awsS3.endpoint.href,path.posix.join(s3opts.aws.bucket,s3opts.prefix)].join('');
      Severity: Major
      Found in lib/condensation/tasks/build.js - About 4 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        module.exports = function fnEquals(v1,v2,options) {
  v1 = cUtil.parse(v1);
  v2 = cUtil.parse(v2);
  options = _.merge({hash: {}}, options);
        Severity: Major
        Found in lib/condensation/template-helpers/functions/fnEquals.js and 1 other location - About 4 hrs to fix
        lib/condensation/template-helpers/functions/fnGetAtt.js on lines 14..32

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 118.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        module.exports = function fnGetAtt(logicalId, attributeName, options) {
  logicalId = cUtil.parse(logicalId);
  attributeName = cUtil.parse(attributeName);

  options = _.merge({hash: {}}, options);
        Severity: Major
        Found in lib/condensation/template-helpers/functions/fnGetAtt.js and 1 other location - About 4 hrs to fix
        lib/condensation/template-helpers/functions/fnEquals.js on lines 13..27

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 118.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function helper has 100 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          var helper = function(cModule,pPath,hArgs,hOpts,cOpts) {

    var engine = cOpts.handlebars;
    var data = cOpts.handlebars.createFrame(hOpts.data || {});
        Severity: Major
        Found in lib/condensation/template-helpers/sections/_buildHelper.js - About 4 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          module.exports = function fnGetParam(artifactName, JSONFileName, keyName, options) {
  options = _.merge({hash: {}}, options);

  artifactName = cValue(artifactName, options);
  JSONFileName = cValue(JSONFileName, options);
          Severity: Major
          Found in lib/condensation/template-helpers/functions/fnGetParam.js and 1 other location - About 3 hrs to fix
          lib/condensation/template-helpers/functions/fnFindInMap.js on lines 15..24

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          module.exports = function fnFindInMap(mapName, topLevelKey, secondLevelKey, options) {
  options = _.merge({hash: {}}, options);

  mapName = cValue(mapName, options);
  topLevelKey = cValue(topLevelKey, options);
          Severity: Major
          Found in lib/condensation/template-helpers/functions/fnFindInMap.js and 1 other location - About 3 hrs to fix
          lib/condensation/template-helpers/functions/fnGetParam.js on lines 15..24

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function loadParticle has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

          ParticleLoader.prototype.loadParticle = function(type,cModule,pPath,options) {
  var loadError = new VError("particle load error");

  var opts = _.merge({
    parentFile: null,
          Severity: Minor
          Found in lib/condensation/loaders/particle-loader.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function stream has 64 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            var stream = es.readable(function(esCount,streamCb) {
    var readable = this;

    var totalCount = 0;
    var lastTotalCount = 0;
          Severity: Major
          Found in lib/condensation/tasks/build.js - About 2 hrs to fix

            Function loadParticle has 60 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            ParticleLoader.prototype.loadParticle = function(type,cModule,pPath,options) {
  var loadError = new VError("particle load error");

  var opts = _.merge({
    parentFile: null,
            Severity: Major
            Found in lib/condensation/loaders/particle-loader.js - About 2 hrs to fix

              Function processTemplate has 56 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              var processTemplate = function(conf) {

  var engine = conf.cOpts.handlebars;
  var templateContent = '';
              Severity: Major
              Found in lib/condensation/template-helpers/sections/_buildHelper.js - About 2 hrs to fix

                Function runStreams has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    var runStreams = function(globs,options) {
      var s = gulp.src(globs,options)
      .pipe(cache(self.options.projectName+distPath))
      .pipe(through.obj(function(file,enc,cb) {
        file._templateFormat = cUtil.detectFormat({
                Severity: Major
                Found in lib/condensation/tasks/build.js - About 2 hrs to fix

                  Function loadHelper has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                  Open

                  var loadHelper = function(helperDefinition,options) {
  var cOpts = _.merge({
    handlebars: Handlebars,
    projectDir: process.cwd(),
    particleLoader: null,
                  Severity: Minor
                  Found in lib/condensation/loaders/template-helper-loader.js - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function layout has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  var helper = function layout(cModule,pPath,hArgs,hOpts,cOpts) {

  var engine = cOpts.handlebars;
  var data = engine.createFrame(hOpts.data || {});
  data._isLayout = true;
                  Severity: Minor
                  Found in lib/condensation/template-helpers/layout.js - About 1 hr to fix

                    Function exports has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    module.exports = function(options) {

  var helpers = {
    arrayify: require('../template-helpers/arrayify'),
    assetPath: loadTemplateHelper(require('../template-helpers/assetPath'),options),
                    Severity: Minor
                    Found in lib/condensation/loaders/all-helpers.js - About 1 hr to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      module.exports = function fnImportValue(sharedValue, options) {
  options = _.merge({hash: {}}, options);

  sharedValue = cValue(sharedValue, options);
                      Severity: Major
                      Found in lib/condensation/template-helpers/functions/fnImportValue.js and 1 other location - About 1 hr to fix
                      lib/condensation/template-helpers/functions/fnGetAZs.js on lines 13..20

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 68.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language