Sign upLogin

SungardAS/waterline-servicenow-soap

View on GitHub
Star

Showing 13 of 13 total issues

Function exports has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (function () {


  // You'll want to maintain a reference to each connection
  // that gets registered with this adapter.
Severity: Major
Found in lib/adapter.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    var Query = module.exports = function(collection) {
  this.collectionName = collection.adapter.collection;
  this._schema = _.clone(collection.definition);
  this._collection = collection;
  return this;
    Severity: Major
    Found in lib/query.js and 1 other location - About 2 hrs to fix
    lib/sql.js on lines 6..11

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    var SQL = module.exports = function(collection) {
  this.collectionName = collection.adapter.collection;
  this._schema = _.clone(collection.definition);
  this._collection = collection;
  return this;
    Severity: Major
    Found in lib/sql.js and 1 other location - About 2 hrs to fix
    lib/query.js on lines 6..11

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function build has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Query.prototype.build = function(options,cb) {
  var self = this,
    encodedQuery = [],
    collection = this._collection,
    query = {};
    Severity: Minor
    Found in lib/query.js - About 2 hrs to fix

      Function initialize has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Resource.prototype.initialize = function(cb) {
  var self = this;

  var basicAuth = new soap.BasicAuthSecurity(this.config.username, this.config.password);
      Severity: Minor
      Found in lib/resource.js - About 1 hr to fix

        Function encodeQuery has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Query.prototype.encodeQuery = function(query,cb) {
  var self = this,
    encodedQuery = [];

  query = query || {};
        Severity: Minor
        Found in lib/query.js - About 1 hr to fix

          Function baseTables has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              baseTables: function(baseTablesCb,results) {
      async.each(
        _.toPairs(self.collections),
        function loadCollections(colDef,loadCb) {
          var collectionName = colDef[0];
          Severity: Minor
          Found in lib/resource.js - About 1 hr to fix

            Function inflate has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            Query.prototype.inflate = function(values,cb) {
  var self = this,
    _values = _.clone(values);

  Object.keys(values).forEach(function(key) {
            Severity: Minor
            Found in lib/query.js - About 1 hr to fix

              Function exports has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

              module.exports = (function () {


  // You'll want to maintain a reference to each connection
  // that gets registered with this adapter.
              Severity: Minor
              Found in lib/adapter.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function update has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              Resource.prototype.update = function(collectionName,options,values,waterlineCb) {
  var collection = this.collections[collectionName];
  var self = this;
  if (options.where && options.where.sys_id) {
    values.sys_id = values.sys_id || options.where.sys_id;
              Severity: Minor
              Found in lib/resource.js - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function build has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              Query.prototype.build = function(options,cb) {
  var self = this,
    encodedQuery = [],
    collection = this._collection,
    query = {};
              Severity: Minor
              Found in lib/query.js - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function update has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  update: function (connection, collection, options, values, cb) {
              Severity: Minor
              Found in lib/adapter.js - About 35 mins to fix

                Function destroy has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    destroy: function (connection, collection, options, values, cb) {
                Severity: Minor
                Found in lib/adapter.js - About 35 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language