Sign upLogin

Swati4star/Images-to-PDF

View on GitHub
Star
app/src/main/java/swati4star/createpdf/fragment/QrBarcodeScanFragment.java

Summary

Maintainability
D
1 day
Test Coverage

Method onClick has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public void onClick(View v) {
        switch (v.getId()) {
            case R.id.scan_qrcode:
                if (Build.VERSION.SDK_INT >= 23) {
Severity: Minor
Found in app/src/main/java/swati4star/createpdf/fragment/QrBarcodeScanFragment.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File QrBarcodeScanFragment.java has 293 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package swati4star.createpdf.fragment;

import static swati4star.createpdf.util.Constants.DEFAULT_BORDER_WIDTH;
import static swati4star.createpdf.util.Constants.DEFAULT_COMPRESSION;
import static swati4star.createpdf.util.Constants.DEFAULT_IMAGE_BORDER_TEXT;
Severity: Minor
Found in app/src/main/java/swati4star/createpdf/fragment/QrBarcodeScanFragment.java - About 3 hrs to fix

    Method onRequestPermissionsResult has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
        super.onRequestPermissionsResult(requestCode, permissions, grantResults);

        if ((requestCode == REQUEST_CODE_FOR_QR_CODE || requestCode == REQUEST_CODE_FOR_BARCODE || requestCode == REQUEST_CODE_FOR_WRITE_PERMISSION) && grantResults.length > 0) {
    Severity: Minor
    Found in app/src/main/java/swati4star/createpdf/fragment/QrBarcodeScanFragment.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method showPermissionDenyDialog has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private void showPermissionDenyDialog(int requestCode) {
        String scanType, permissionType;
        if (requestCode == REQUEST_CODE_FOR_QR_CODE) {
            scanType = "QR-Code";
            permissionType = "Camera";
    Severity: Minor
    Found in app/src/main/java/swati4star/createpdf/fragment/QrBarcodeScanFragment.java - About 1 hr to fix

      Method onClick has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @Override
    public void onClick(View v) {
        switch (v.getId()) {
            case R.id.scan_qrcode:
                if (Build.VERSION.SDK_INT >= 23) {
      Severity: Minor
      Found in app/src/main/java/swati4star/createpdf/fragment/QrBarcodeScanFragment.java - About 1 hr to fix

        Method showPermissionDenyDialog has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private void showPermissionDenyDialog(int requestCode) {
        String scanType, permissionType;
        if (requestCode == REQUEST_CODE_FOR_QR_CODE) {
            scanType = "QR-Code";
            permissionType = "Camera";
        Severity: Minor
        Found in app/src/main/java/swati4star/createpdf/fragment/QrBarcodeScanFragment.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    case R.id.scan_qrcode:
                if (Build.VERSION.SDK_INT >= 23) {
                    if (isCameraPermissionGranted()) {
                        if (PermissionsUtils.getInstance().checkRuntimePermissions(this, WRITE_PERMISSIONS)) {
                            openScanner(IntentIntegrator.QR_CODE_TYPES, R.string.scan_qrcode);
        Severity: Major
        Found in app/src/main/java/swati4star/createpdf/fragment/QrBarcodeScanFragment.java and 1 other location - About 1 hr to fix
        app/src/main/java/swati4star/createpdf/fragment/QrBarcodeScanFragment.java on lines 138..150

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    case R.id.scan_barcode:
                if (Build.VERSION.SDK_INT >= 23) {
                    if (isCameraPermissionGranted()) {
                        if (PermissionsUtils.getInstance().checkRuntimePermissions(this, WRITE_PERMISSIONS)) {
                            openScanner(IntentIntegrator.ONE_D_CODE_TYPES, R.string.scan_barcode);
        Severity: Major
        Found in app/src/main/java/swati4star/createpdf/fragment/QrBarcodeScanFragment.java and 1 other location - About 1 hr to fix
        app/src/main/java/swati4star/createpdf/fragment/QrBarcodeScanFragment.java on lines 125..137

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status