Sign upLogin

Swati4star/Images-to-PDF

View on GitHub
Star
app/src/main/java/swati4star/createpdf/fragment/RemovePagesFragment.java

Summary

Maintainability
C
1 day
Test Coverage

File RemovePagesFragment.java has 313 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package swati4star.createpdf.fragment;

import static android.app.Activity.RESULT_OK;
import static swati4star.createpdf.util.Constants.ADD_PWD;
import static swati4star.createpdf.util.Constants.BUNDLE_DATA;
Severity: Minor
Found in app/src/main/java/swati4star/createpdf/fragment/RemovePagesFragment.java - About 3 hrs to fix

    RemovePagesFragment has 21 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class RemovePagesFragment extends Fragment implements MergeFilesAdapter.OnClickListener,
        OnPDFCompressedInterface, BottomSheetPopulate, OnBackPressedInterface, OnPdfReorderedInterface {

    private static final int INTENT_REQUEST_PICKFILE_CODE = 10;
    private static final int INTENT_REQUEST_REARRANGE_PDF = 11;
    Severity: Minor
    Found in app/src/main/java/swati4star/createpdf/fragment/RemovePagesFragment.java - About 2 hrs to fix

      Method onActivityResult has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          public void onActivityResult(int requestCode, int resultCode, Intent data) throws NullPointerException {
        if (data == null || resultCode != RESULT_OK)
            return;
        if (requestCode == INTENT_REQUEST_PICKFILE_CODE) {
            mUri = data.getData();
      Severity: Minor
      Found in app/src/main/java/swati4star/createpdf/fragment/RemovePagesFragment.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method onActivityResult has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public void onActivityResult(int requestCode, int resultCode, Intent data) throws NullPointerException {
        if (data == null || resultCode != RESULT_OK)
            return;
        if (requestCode == INTENT_REQUEST_PICKFILE_CODE) {
            mUri = data.getData();
      Severity: Minor
      Found in app/src/main/java/swati4star/createpdf/fragment/RemovePagesFragment.java - About 1 hr to fix

        Method parse has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            @OnClick(R.id.pdfCreate)
    public void parse() {
        StringUtils.getInstance().hideKeyboard(mActivity);
        if (mOperation.equals(COMPRESS_PDF)) {
            compressPDF();
        Severity: Minor
        Found in app/src/main/java/swati4star/createpdf/fragment/RemovePagesFragment.java - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

            @Override
    public void onAttach(Context context) {
        super.onAttach(context);
        mActivity = (Activity) context;
        mMorphButtonUtility = new MorphButtonUtility(mActivity);
        Severity: Major
        Found in app/src/main/java/swati4star/createpdf/fragment/RemovePagesFragment.java and 2 other locations - About 50 mins to fix
        app/src/main/java/swati4star/createpdf/fragment/AddImagesFragment.java on lines 239..247
        app/src/main/java/swati4star/createpdf/fragment/SplitFilesFragment.java on lines 156..164

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status