Sign upLogin

Syndesi/cypher-data-structures

View on GitHub
Star

Showing 22 of 23 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static function relationConstraintToString(RelationConstraintInterface $relationConstraint): string
    {
        $parts = [];

        $parts[] = 'CONSTRAINT';
Severity: Major
Found in src/Helper/ToStringHelper.php and 1 other location - About 1 day to fix
src/Helper/ToStringHelper.php on lines 268..320

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 398.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static function nodeConstraintToString(NodeConstraintInterface $nodeConstraint): string
    {
        $parts = [];

        $parts[] = 'CONSTRAINT';
Severity: Major
Found in src/Helper/ToStringHelper.php and 1 other location - About 1 day to fix
src/Helper/ToStringHelper.php on lines 322..374

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 398.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static function relationIndexToString(RelationIndexInterface $relationIndex): string
    {
        $parts = [];

        $type = $relationIndex->getType();
Severity: Major
Found in src/Helper/ToStringHelper.php and 1 other location - About 1 day to fix
src/Helper/ToStringHelper.php on lines 376..420

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 333.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static function nodeIndexToString(NodeIndexInterface $nodeIndex): string
    {
        $parts = [];

        $type = $nodeIndex->getType();
Severity: Major
Found in src/Helper/ToStringHelper.php and 1 other location - About 1 day to fix
src/Helper/ToStringHelper.php on lines 422..466

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 333.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File ToStringHelper.php has 364 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Syndesi\CypherDataStructures\Helper;
Severity: Minor
Found in src/Helper/ToStringHelper.php - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    <?php

declare(strict_types=1);

namespace Syndesi\CypherDataStructures\Type;
    Severity: Major
    Found in src/Type/Constraint.php and 1 other location - About 4 hrs to fix
    src/Type/Index.php on lines 1..57

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 168.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    <?php

declare(strict_types=1);

namespace Syndesi\CypherDataStructures\Type;
    Severity: Major
    Found in src/Type/Index.php and 1 other location - About 4 hrs to fix
    src/Type/Constraint.php on lines 1..57

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 168.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function valueToString has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function valueToString(mixed $value): string
    {
        if (is_string($value)) {
            return sprintf("'%s'", self::escapeString($value));
        }
    Severity: Minor
    Found in src/Helper/ToStringHelper.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method valueToString has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function valueToString(mixed $value): string
    {
        if (is_string($value)) {
            return sprintf("'%s'", self::escapeString($value));
        }
    Severity: Minor
    Found in src/Helper/ToStringHelper.php - About 1 hr to fix

      Method nodeConstraintToString has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function nodeConstraintToString(NodeConstraintInterface $nodeConstraint): string
    {
        $parts = [];

        $parts[] = 'CONSTRAINT';
      Severity: Minor
      Found in src/Helper/ToStringHelper.php - About 1 hr to fix

        Method relationConstraintToString has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function relationConstraintToString(RelationConstraintInterface $relationConstraint): string
    {
        $parts = [];

        $parts[] = 'CONSTRAINT';
        Severity: Minor
        Found in src/Helper/ToStringHelper.php - About 1 hr to fix

          Method relationIndexToString has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function relationIndexToString(RelationIndexInterface $relationIndex): string
    {
        $parts = [];

        $type = $relationIndex->getType();
          Severity: Minor
          Found in src/Helper/ToStringHelper.php - About 1 hr to fix

            Method nodeIndexToString has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function nodeIndexToString(NodeIndexInterface $nodeIndex): string
    {
        $parts = [];

        $type = $nodeIndex->getType();
            Severity: Minor
            Found in src/Helper/ToStringHelper.php - About 1 hr to fix

              Method relationToString has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public static function relationToString(RelationInterface $relation, bool $identifying = false, bool $withNodes = true): string
    {
        $parts = [];
        if ($withNodes) {
            if (($startNode = $relation->getStartNode()) === null) {
              Severity: Minor
              Found in src/Helper/ToStringHelper.php - About 1 hr to fix

                Function relationConstraintToString has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function relationConstraintToString(RelationConstraintInterface $relationConstraint): string
    {
        $parts = [];

        $parts[] = 'CONSTRAINT';
                Severity: Minor
                Found in src/Helper/ToStringHelper.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function nodeConstraintToString has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function nodeConstraintToString(NodeConstraintInterface $nodeConstraint): string
    {
        $parts = [];

        $parts[] = 'CONSTRAINT';
                Severity: Minor
                Found in src/Helper/ToStringHelper.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function relationToString has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function relationToString(RelationInterface $relation, bool $identifying = false, bool $withNodes = true): string
    {
        $parts = [];
        if ($withNodes) {
            if (($startNode = $relation->getStartNode()) === null) {
                Severity: Minor
                Found in src/Helper/ToStringHelper.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this method.
                Open

                            return sprintf("[%s]", $parts);
                Severity: Major
                Found in src/Helper/ToStringHelper.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return self::NO_STRING_REPRESENTATION;
                  Severity: Major
                  Found in src/Helper/ToStringHelper.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return (string) $value;
                    Severity: Major
                    Found in src/Helper/ToStringHelper.php - About 30 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language