Sign upLogin

SysMO-DB/seek

View on GitHub
Star
app/controllers/jerm_controller.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method insert_results has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def insert_results
    resources=[]
    @project=Project.find(params[:project])
    params.keys.each do |key|
      if key.start_with?("title")
Severity: Minor
Found in app/controllers/jerm_controller.rb - About 1 hr to fix

    Method fetch has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def fetch    
    @project=Project.find(params[:project])
    @project.decrypt_credentials
    if @project.site_root_uri.blank?
      flash.now[:error]="No remote site location defined"
    Severity: Minor
    Found in app/controllers/jerm_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method fetch has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def fetch    
    @project=Project.find(params[:project])
    @project.decrypt_credentials
    if @project.site_root_uri.blank?
      flash.now[:error]="No remote site location defined"
    Severity: Minor
    Found in app/controllers/jerm_controller.rb - About 1 hr to fix

      Method insert_results has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def insert_results
    resources=[]
    @project=Project.find(params[:project])
    params.keys.each do |key|
      if key.start_with?("title")
      Severity: Minor
      Found in app/controllers/jerm_controller.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method inform_authors has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def inform_authors
    resources = {}
    @responses.each do |r|
      if r[:seek_model] && r[:author]
        resources[r[:author]] ||= []
      Severity: Minor
      Found in app/controllers/jerm_controller.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status