Sign upLogin

SysMO-DB/seek

View on GitHub
Star
app/helpers/menu_helper.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method menu_definitions has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def menu_definitions
    definitions=[
        {:title=>t("menu.yellow_pages"), :sections=>[
            {:controller=>"programmes",:title=>t('programme').pluralize,:hide=>!Seek::Config.programmes_enabled},
            {:controller=>"people",:title=>"People"},
Severity: Minor
Found in app/helpers/menu_helper.rb - About 1 hr to fix

    Method section_menu_items has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def section_menu_items sections
    sections||=[]
    selected_section = current_second_level_section sections
    sections.collect do |section|
      unless section[:hide]
    Severity: Minor
    Found in app/helpers/menu_helper.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method top_level_menu_tabs has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def top_level_menu_tabs definitions
    selected_tab = current_top_level_tab(definitions)
    definitions.select{|d| !d[:hide]}.collect do |menu|
      attributes = ""
      attributes << "id = 'selected_tabnav'" if selected_tab == menu
    Severity: Minor
    Found in app/helpers/menu_helper.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status