Sign upLogin

SysMO-DB/seek

View on GitHub
Star
app/helpers/models_helper.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method allow_model_comparison has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def allow_model_comparison model,displayed_model,user=User.current_user
    return false unless model.is_a?(Model)
    return false unless model.can_download?(user)
    return false unless displayed_model.contains_sbml?
    return false unless model.versions.select{|v| v.contains_sbml?}.count > 1
Severity: Minor
Found in app/helpers/models_helper.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method compare_model_version_selection has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def compare_model_version_selection versioned_model, displayed_resource_version
    versions=versioned_model.versions.reverse
    disabled=versions.size==1
    options=""
    versions.each do |v|
Severity: Minor
Found in app/helpers/models_helper.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status