Sign upLogin

TINYhr/tiny_client

View on GitHub
Star

Showing 6 of 6 total issues

Class Resource has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Resource
    include PaginationSupport
    include NestedSupport

    class << self
Severity: Minor
Found in lib/tiny_client/resource.rb - About 2 hrs to fix

    Method perform_post has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def perform_post(url, headers, content, connect_timeout, verbose)
    Severity: Minor
    Found in lib/tiny_client/curb_requestor.rb - About 35 mins to fix

      Method perform_put has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def perform_put(url, headers, content, connect_timeout, verbose)
      Severity: Minor
      Found in lib/tiny_client/curb_requestor.rb - About 35 mins to fix

        Method perform has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def perform(verb, url, post_body, put_data, options = {})
        Severity: Minor
        Found in lib/tiny_client/curb_requestor.rb - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def post(data, path, id, name)
      url = @config.url_for(path, id, name)
      verify_json(data)
      CurbRequestor.perform_post(url, {
        'Accept' => 'application/json',
          Severity: Minor
          Found in lib/tiny_client/remote_client.rb and 1 other location - About 20 mins to fix
          lib/tiny_client/remote_client.rb on lines 36..42

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def put(data, path, id, name)
      url = @config.url_for(path, id, name)
      verify_json(data)
      CurbRequestor.perform_put(url, {
        'Accept' => 'application/json',
          Severity: Minor
          Found in lib/tiny_client/remote_client.rb and 1 other location - About 20 mins to fix
          lib/tiny_client/remote_client.rb on lines 23..29

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language