Sign upLogin

TNOCS/node-auth

View on GitHub
Star

Showing 41 of 41 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  if (!user.admin && user._id.toString() !== id) {
    res.status(UNAUTHORIZED).json({ success: false, message: 'You are not authorised to request this user.' });
    return;
  }
Severity: Major
Found in src/lib/routes/user.ts and 2 other locations - About 1 hr to fix
src/lib/routes/user.ts on lines 207..210
src/lib/routes/user.ts on lines 251..254

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  if (!user.admin && user._id.toString() !== id) {
    res.status(UNAUTHORIZED).json({ success: false, message: 'Request denied' });
    return;
  }
Severity: Major
Found in src/lib/routes/user.ts and 2 other locations - About 1 hr to fix
src/lib/routes/user.ts on lines 68..71
src/lib/routes/user.ts on lines 207..210

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getPolicyEditor has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  const getPolicyEditor = (policyName: string, policySetName: string) => {
    const name = createPolicyName(policySetName, policyName);
    const ruleCollection = db.getCollection<IRule>(name);
    const getRules = (req: IPermissionRequest) => {
      return ruleCollection
Severity: Minor
Found in src/lib/authorize/policy-store.ts - About 1 hr to fix

    Function verifyEmail has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function verifyEmail(req: Request, res: Response) {
  const id = req.params['id'];
  const token = req.query['t'];
  if (!id || !token) {
    res.status(BAD_REQUEST).json({ success: false, message: 'Please create a valid request!' });
    Severity: Minor
    Found in src/lib/routes/verify.ts - About 1 hr to fix

      Function createApiRoute has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function createApiRoute(apiRoutes: express.Router, options: INodeAuthOptions) {
  let routes = [];

  const apiRoute = (options.api && typeof options.api === 'string') ? options.api : '/api';
      Severity: Minor
      Found in src/lib/node-auth.ts - About 1 hr to fix

        Function login has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function login(req: Request, res: Response) {
  const email = req['body'].email;
  const pwd = req['body'].password;

  const token = getToken(req);
        Severity: Minor
        Found in src/lib/routes/login.ts - About 1 hr to fix

          Function authenticateUser has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function authenticateUser(secretKey: string, blockUnauthenticatedUser = true) {
  const authnErrorHandler = blockUnauthenticatedUser
    ? (req: express.Request, res: express.Response, next: express.NextFunction, msg?: string) => {
      // AuthN failed, so return an error.
      res.status(UNAUTHORIZED).json({
          Severity: Minor
          Found in src/lib/node-auth.ts - About 1 hr to fix

            Function updateUser has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export function updateUser(req: Request, res: Response) {
  const updatedUser: IUser = req['body'];
  const id: string = req.params['id'];
  const user: IUser = req['user'];
            Severity: Minor
            Found in src/lib/routes/user.ts - About 1 hr to fix

              Function createPrivileges has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              export function createPrivileges(req: Request, res: Response) {
  const handler = (newPrivilegeReq: IPrivilegeRequest) => {
    return (msg: ResponseMessage) => {
      if (msg.success) {
        const ruleStatus = createPrivilege(newPrivilegeReq);
              Severity: Minor
              Found in src/lib/routes/authorize.ts - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function deletePrivileges has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              export function deletePrivileges(req: Request, res: Response) {
  const handler = (newPrivilege: IPrivilegeRequest) => {
    return (msg: ResponseMessage) => {
      if (msg.success) {
        const ruleStatus = deletePrivilege(newPrivilege);
              Severity: Minor
              Found in src/lib/routes/authorize.ts - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function updatePrivileges has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              export function updatePrivileges(req: Request, res: Response) {
  const handler = (newPrivilege: IPrivilegeRequest) => {
    return (msg: ResponseMessage) => {
      if (msg.success) {
        const ruleStatus = updatePrivilege(newPrivilege);
              Severity: Minor
              Found in src/lib/routes/authorize.ts - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function createApiRoute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              function createApiRoute(apiRoutes: express.Router, options: INodeAuthOptions) {
  let routes = [];

  const apiRoute = (options.api && typeof options.api === 'string') ? options.api : '/api';
              Severity: Minor
              Found in src/lib/node-auth.ts - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getPolicyEditor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              function getPolicyEditor(newPrivilege: IPrivilegeRequest) {
  const policy = newPrivilege.policy || -1;
  if (typeof policy === 'number') {
    const policySet = policyStore.getPolicySet(newPrivilege.policySet);
    if (policy >= policySet.policies.length) { return null; }
              Severity: Minor
              Found in src/lib/routes/authorize.ts - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

              function createPrivilege(newPrivilege: IPrivilegeRequest) {
  const policyEditor = getPolicyEditor(newPrivilege);
  if (!policyEditor) { return null; }
  return policyEditor('add', newPrivilege);
}
              Severity: Minor
              Found in src/lib/routes/authorize.ts and 2 other locations - About 35 mins to fix
              src/lib/routes/authorize.ts on lines 41..45
              src/lib/routes/authorize.ts on lines 47..51

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

              function deletePrivilege(newPrivilege: IPrivilegeRequest) {
  const policyEditor = getPolicyEditor(newPrivilege);
  if (!policyEditor) { return null; }
  return policyEditor('delete', newPrivilege);
}
              Severity: Minor
              Found in src/lib/routes/authorize.ts and 2 other locations - About 35 mins to fix
              src/lib/routes/authorize.ts on lines 35..39
              src/lib/routes/authorize.ts on lines 41..45

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

              function updatePrivilege(newPrivilege: IPrivilegeRequest) {
  const policyEditor = getPolicyEditor(newPrivilege);
  if (!policyEditor) { return null; }
  return policyEditor('update', newPrivilege);
}
              Severity: Minor
              Found in src/lib/routes/authorize.ts and 2 other locations - About 35 mins to fix
              src/lib/routes/authorize.ts on lines 35..39
              src/lib/routes/authorize.ts on lines 47..51

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this function.
              Open

                    if (!matchProperties(rule.resource[key], req.resource[key])) { return false; };
              Severity: Major
              Found in src/lib/authorize/policy-store.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return ruleProp === reqProp[0];
                Severity: Major
                Found in src/lib/authorize/policy-store.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    return true;
                  Severity: Major
                  Found in src/lib/authorize/policy-store.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return ruleProp === reqProp;
                    Severity: Major
                    Found in src/lib/authorize/policy-store.ts - About 30 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language