Showing 179 of 179 total issues
Function run
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
run(cloudbridge, argv) {
var appserver = new AppServer({
target: paths.get("APPSERVER", this.projectDir)
}),
smartclient = new SmartClient({
Function run
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
run(cloudbridge, argv) {
var appserver = new AppServer({
target: paths.get("APPSERVER", this.projectDir)
}),
smartclient = new SmartClient({
Function startApp
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
static startApp(options) {
if (typeof options !== 'object' || typeof options === 'undefined') {
throw new Error('You cannot start an app without options');
}
Function run
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
run(cloudbridge, argv) {
var _this = this,
platforms = _this.getPlatforms(argv);
if (platforms.length === 0) {
Function getTaskWithName
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
TASKS.getTaskWithName = function getTaskWithName(name) {
for (var i = 0; i < TASKS.length; i++) {
var t = TASKS[i];
if (t.name === name) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function run
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
run(cloudbridge, argv) {
if (argv._.length < 2) {
return utils.fail('Invalid command', 'start');
}
Function promptForOverwrite
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
static promptForOverwrite(targetPath, _argv) {
var deferred = Q.defer(),
choiceOverwrite = {
name: 'Overwrite',
value: 0,
Function promptForOverwrite
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
static promptForOverwrite(targetPath, _argv) {
var deferred = Q.defer(),
choiceOverwrite = {
name: 'Overwrite',
value: 0,
Function promptForOverwrite
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
static promptForOverwrite(targetPath, _argv) {
var deferred = Q.defer(),
choiceOverwrite = {
name: 'Overwrite',
value: 0,
Function run
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
run(cloudbridge, argv) {
if (argv._.length < 2) {
return utils.fail('Invalid command', 'start');
}
Similar blocks of code found in 2 locations. Consider refactoring. Open
static configSet(p1, p2, p3) {
var command = 'ionic config set ' + Array.prototype.join.call(arguments, ' ');
shelljs.exec(command, { silent: true, stdio: 'ignore' });
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 62.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
static configUnset(p1, p2, p3) {
var command = 'ionic config unset ' + Array.prototype.join.call(arguments, ' ');
shelljs.exec(command, { silent: true, stdio: 'ignore' });
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 62.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function run
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
run(cloudbridge, argv) {
let forceClean = this.needClean(argv),
task,
promise,
noADVPL = false;
Function run
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
run(cloudbridge, argv) {
let forceClean = this.needClean(argv),
task,
promise,
noADVPL = false;
Function run
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
run(cloudbridge, argv) {
let forceClean = this.needClean(argv),
task,
promise,
noADVPL = false;
Function run
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
run(cloudbridge, argv) {
let forceClean = this.needClean(argv),
task,
promise,
noADVPL = false;
Similar blocks of code found in 2 locations. Consider refactoring. Open
result.latest = Math.max.apply(Math, items.map(function(item) {
return item.latest.length + item.modifier.length;
}));
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 61.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
result.current = Math.max.apply(Math, items.map(function(item) {
return item.current.length + item.modifier.length;
}));
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 61.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function update
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
update(platforms) {
var _this = this,
projectData = this.project.data();
if (platforms.length === 0) {
Function fetchWrapper
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
static fetchWrapper(options) {
var pack = new Package('cloudbridge-core-cordova');
return Q()
.then(function() {