src/app/state/article.reducer.ts from Takumon/mean-blog

Function `reducer` has 159 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function reducer(
  state = initialState,
  action: ArticleActions
): State {
  switch (action.type) {

Found in src/app/state/article.reducer.ts - About 6 hrs to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {...state, loading: true} );

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {...state, loading: false} );

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {...state, loading: true} );

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {...state, loadingVote: true});

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {...state });

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {
        ...state,
        article: {
          ...state.article,
          vote: action.payload.vote

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {...state, loadingVote: false} );

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return adapter.addOne(action.payload.article, {
        ...state,
        loading: false
      });

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return adapter.removeOne(action.payload.article._id, {
        ...state,
        loading: false
      });

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {...state });

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {...state, loading: true});

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {...state, loadingVote: false} );

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {...state, loading: false} );

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return adapter.updateOne({
        id: action.payload._idOfArticle,
        changes: {
          vote: action.payload.vote
        }

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {
        ...state,
        article: action.payload.article,
        loadingArticle: false,
      });

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return adapter.removeMany(action.payload.ids, state);

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {...state, loading: false} );

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {...state, loading: true });

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return adapter.updateOne({
        id: action.payload._idOfArticle,
        changes: {
          vote: action.payload.vote
        }

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {
        ...state,
        article: null,
        loadingArticle: false,
      });

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {...state, loading: true} );

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return state;

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return adapter.removeAll(state);

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {...state, loadingArticle: true, article: null} );

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {...state, loadingVote: true});

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return adapter.addAll(action.payload.articles, {
        ...state,
        count: action.payload.count,
        loading: false
      } );

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return adapter.updateOne(action.payload.article, {
        ...state,
        loading: false
      });

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {
        ...state,
        loading: false,
      });

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {...state, loadingArticle: false} );

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {...state, loadingArticle: false});

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return Object.assign({}, {
        ...state,
        article: {
          ...state.article,
          vote: action.payload.vote

Found in src/app/state/article.reducer.ts - About 30 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    case ArticleActionTypes.AddVoteSuccess: {
      return Object.assign({}, {
        ...state,
        article: {
          ...state.article,

Found in src/app/state/article.reducer.ts and 1 other location - About 1 hr to fix

Read up
Read up

src/app/state/article.reducer.ts on lines 228..237

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Takumon/mean-blog

Summary

Maintainability

Test Coverage

Function reducer has 159 lines of code (exceeds 25 allowed). Consider refactoring. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Similar blocks of code found in 2 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

There are no issues that match your filters.

Category

Status

Function `reducer` has 159 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Similar blocks of code found in 2 locations. Consider refactoring.
Open