TargetProcess/tauCharts

View on GitHub
src/api/chart-line.ts

Summary

Maintainability
D
1 day
Test Coverage

Function ChartLine has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const ChartLine = (rawConfig: ChartConfig) => {
    var config = normalizeConfig(rawConfig);

    var data = config.data;

Severity: Major
Found in src/api/chart-line.ts - About 2 hrs to fix

    Function auto has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            auto: (config) => {
                var xs = config.x;
                var ys = config.y;
                var primaryX = xs[xs.length - 1];
                var secondaryX = xs.slice(0, xs.length - 1);
    Severity: Minor
    Found in src/api/chart-line.ts - About 1 hr to fix

      Function ChartLine has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      const ChartLine = (rawConfig: ChartConfig) => {
          var config = normalizeConfig(rawConfig);
      
          var data = config.data;
      
      
      Severity: Minor
      Found in src/api/chart-line.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  var isMatchAny = variations.some((item, i) => {
                      var domainFields = item[0];
                      var rangeProperty = item[1];
                      var r = DataProcessor.isYFunctionOfX(data, domainFields, [rangeProperty]);
                      if (r.result) {
      Severity: Major
      Found in src/api/chart-line.ts and 1 other location - About 1 day to fix
      src/api/chart-area.ts on lines 45..60

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 204.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

          var lineOrientationStrategies = {
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Shadowed name: 'config'
      Open

              horizontal: (config) => {
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-shadowed-variable

      Disallows shadowing variable declarations.

      Rationale

      When a variable in a local scope and a variable in the containing scope have the same name, shadowing occurs. Shadowing makes it impossible to access the variable in the containing scope and obscures to what value an identifier actually refers. Compare the following snippets:

      const a = 'no shadow';
      function print() {
          console.log(a);
      }
      print(); // logs 'no shadow'.
      const a = 'no shadow';
      function print() {
          const a = 'shadow'; // TSLint will complain here.
          console.log(a);
      }
      print(); // logs 'shadow'.

      ESLint has an equivalent rule. For more background information, refer to this MDN closure doc.

      Config

      You can optionally pass an object to disable checking for certain kinds of declarations. Possible keys are "class", "enum", "function", "import", "interface", "namespace", "typeAlias" and "typeParameter". You can also pass "underscore" to ignore variable names that begin with _. Just set the value to false for the check you want to disable. All checks default to true, i.e. are enabled by default. Note that you cannot disable variables and parameters.

      The option "temporalDeadZone" defaults to true which shows errors when shadowing block scoped declarations in their temporal dead zone. When set to false parameters, classes, enums and variables declared with let or const are not considered shadowed if the shadowing occurs within their temporal dead zone.

      The following example shows how the "temporalDeadZone" option changes the linting result:

      function fn(value) {
          if (value) {
              const tmp = value; // no error on this line if "temporalDeadZone" is false
              return tmp;
          }
          let tmp = undefined;
          if (!value) {
              const tmp = value; // this line always contains an error
              return tmp;
          }
      }
      Examples
      "no-shadowed-variable": true
      "no-shadowed-variable": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "class": {
            "type": "boolean"
          },
          "enum": {
            "type": "boolean"
          },
          "function": {
            "type": "boolean"
          },
          "import": {
            "type": "boolean"
          },
          "interface": {
            "type": "boolean"
          },
          "namespace": {
            "type": "boolean"
          },
          "typeAlias": {
            "type": "boolean"
          },
          "typeParameter": {
            "type": "boolean"
          },
          "temporalDeadZone": {
            "type": "boolean"
          },
          "underscore": {
            "type": "boolean"
          }
        }
      }

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                  var primaryY = ys[ys.length - 1];
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Identifier 'r' is never reassigned; use 'const' instead of 'var'.
      Open

                      var r = DataProcessor.isYFunctionOfX(data, domainFields, [rangeProperty]);
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                  var ys = config.y;
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Identifier 'domainFields' is never reassigned; use 'const' instead of 'var'.
      Open

                      var domainFields = item[0];
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Identifier 'log' is never reassigned; use 'const' instead of 'var'.
      Open

          var log = config.settings.log;
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

          var data = config.data;
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Identifier 'colorProp' is never reassigned; use 'const' instead of 'var'.
      Open

                  var colorProp = config.color;
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Identifier 'ys' is never reassigned; use 'const' instead of 'var'.
      Open

                  var ys = config.y;
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Identifier 'config' is never reassigned; use 'const' instead of 'var'.
      Open

          var config = normalizeConfig(rawConfig);
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Identifier 'strategy' is never reassigned; use 'const' instead of 'var'.
      Open

          var strategy = lineOrientationStrategies.hasOwnProperty(orient) ?
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                  var primaryX = xs[xs.length - 1];
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                      var rangeProperty = item[1];
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Shadowed name: 'config'
      Open

              auto: (config) => {
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-shadowed-variable

      Disallows shadowing variable declarations.

      Rationale

      When a variable in a local scope and a variable in the containing scope have the same name, shadowing occurs. Shadowing makes it impossible to access the variable in the containing scope and obscures to what value an identifier actually refers. Compare the following snippets:

      const a = 'no shadow';
      function print() {
          console.log(a);
      }
      print(); // logs 'no shadow'.
      const a = 'no shadow';
      function print() {
          const a = 'shadow'; // TSLint will complain here.
          console.log(a);
      }
      print(); // logs 'shadow'.

      ESLint has an equivalent rule. For more background information, refer to this MDN closure doc.

      Config

      You can optionally pass an object to disable checking for certain kinds of declarations. Possible keys are "class", "enum", "function", "import", "interface", "namespace", "typeAlias" and "typeParameter". You can also pass "underscore" to ignore variable names that begin with _. Just set the value to false for the check you want to disable. All checks default to true, i.e. are enabled by default. Note that you cannot disable variables and parameters.

      The option "temporalDeadZone" defaults to true which shows errors when shadowing block scoped declarations in their temporal dead zone. When set to false parameters, classes, enums and variables declared with let or const are not considered shadowed if the shadowing occurs within their temporal dead zone.

      The following example shows how the "temporalDeadZone" option changes the linting result:

      function fn(value) {
          if (value) {
              const tmp = value; // no error on this line if "temporalDeadZone" is false
              return tmp;
          }
          let tmp = undefined;
          if (!value) {
              const tmp = value; // this line always contains an error
              return tmp;
          }
      }
      Examples
      "no-shadowed-variable": true
      "no-shadowed-variable": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "class": {
            "type": "boolean"
          },
          "enum": {
            "type": "boolean"
          },
          "function": {
            "type": "boolean"
          },
          "import": {
            "type": "boolean"
          },
          "interface": {
            "type": "boolean"
          },
          "namespace": {
            "type": "boolean"
          },
          "typeAlias": {
            "type": "boolean"
          },
          "typeParameter": {
            "type": "boolean"
          },
          "temporalDeadZone": {
            "type": "boolean"
          },
          "underscore": {
            "type": "boolean"
          }
        }
      }

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                  var isMatchAny = variations.some((item, i) => {
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

          var orient = (config.lineOrientation || '').toLowerCase();
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Identifier 'secondaryX' is never reassigned; use 'const' instead of 'var'.
      Open

                  var secondaryX = xs.slice(0, xs.length - 1);
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                  var colorProp = config.color;
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Identifier 'xs' is never reassigned; use 'const' instead of 'var'.
      Open

                  var xs = config.x;
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Identifier 'primaryX' is never reassigned; use 'const' instead of 'var'.
      Open

                  var primaryX = xs[xs.length - 1];
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Identifier 'rest' is never reassigned; use 'const' instead of 'var'.
      Open

                  var rest = secondaryX.concat(secondaryY).concat([colorProp]).filter((x) => x !== null);
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Identifier 'isMatchAny' is never reassigned; use 'const' instead of 'var'.
      Open

                  var isMatchAny = variations.some((item, i) => {
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Shadowed name: 'config'
      Open

              vertical: (config) => {
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-shadowed-variable

      Disallows shadowing variable declarations.

      Rationale

      When a variable in a local scope and a variable in the containing scope have the same name, shadowing occurs. Shadowing makes it impossible to access the variable in the containing scope and obscures to what value an identifier actually refers. Compare the following snippets:

      const a = 'no shadow';
      function print() {
          console.log(a);
      }
      print(); // logs 'no shadow'.
      const a = 'no shadow';
      function print() {
          const a = 'shadow'; // TSLint will complain here.
          console.log(a);
      }
      print(); // logs 'shadow'.

      ESLint has an equivalent rule. For more background information, refer to this MDN closure doc.

      Config

      You can optionally pass an object to disable checking for certain kinds of declarations. Possible keys are "class", "enum", "function", "import", "interface", "namespace", "typeAlias" and "typeParameter". You can also pass "underscore" to ignore variable names that begin with _. Just set the value to false for the check you want to disable. All checks default to true, i.e. are enabled by default. Note that you cannot disable variables and parameters.

      The option "temporalDeadZone" defaults to true which shows errors when shadowing block scoped declarations in their temporal dead zone. When set to false parameters, classes, enums and variables declared with let or const are not considered shadowed if the shadowing occurs within their temporal dead zone.

      The following example shows how the "temporalDeadZone" option changes the linting result:

      function fn(value) {
          if (value) {
              const tmp = value; // no error on this line if "temporalDeadZone" is false
              return tmp;
          }
          let tmp = undefined;
          if (!value) {
              const tmp = value; // this line always contains an error
              return tmp;
          }
      }
      Examples
      "no-shadowed-variable": true
      "no-shadowed-variable": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "class": {
            "type": "boolean"
          },
          "enum": {
            "type": "boolean"
          },
          "function": {
            "type": "boolean"
          },
          "import": {
            "type": "boolean"
          },
          "interface": {
            "type": "boolean"
          },
          "namespace": {
            "type": "boolean"
          },
          "typeAlias": {
            "type": "boolean"
          },
          "typeParameter": {
            "type": "boolean"
          },
          "temporalDeadZone": {
            "type": "boolean"
          },
          "underscore": {
            "type": "boolean"
          }
        }
      }

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                      var r = DataProcessor.isYFunctionOfX(data, domainFields, [rangeProperty]);
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Identifier 'data' is never reassigned; use 'const' instead of 'var'.
      Open

          var data = config.data;
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                  var secondaryX = xs.slice(0, xs.length - 1);
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Identifier 'secondaryY' is never reassigned; use 'const' instead of 'var'.
      Open

                  var secondaryY = ys.slice(0, ys.length - 1);
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Identifier 'lineOrientationStrategies' is never reassigned; use 'const' instead of 'var'.
      Open

          var lineOrientationStrategies = {
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                  var rest = secondaryX.concat(secondaryY).concat([colorProp]).filter((x) => x !== null);
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                  var secondaryY = ys.slice(0, ys.length - 1);
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                      var domainFields = item[0];
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Identifier 'rangeProperty' is never reassigned; use 'const' instead of 'var'.
      Open

                      var rangeProperty = item[1];
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Shadowed name: 'propSortBy'
      Open

                  var propSortBy;
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-shadowed-variable

      Disallows shadowing variable declarations.

      Rationale

      When a variable in a local scope and a variable in the containing scope have the same name, shadowing occurs. Shadowing makes it impossible to access the variable in the containing scope and obscures to what value an identifier actually refers. Compare the following snippets:

      const a = 'no shadow';
      function print() {
          console.log(a);
      }
      print(); // logs 'no shadow'.
      const a = 'no shadow';
      function print() {
          const a = 'shadow'; // TSLint will complain here.
          console.log(a);
      }
      print(); // logs 'shadow'.

      ESLint has an equivalent rule. For more background information, refer to this MDN closure doc.

      Config

      You can optionally pass an object to disable checking for certain kinds of declarations. Possible keys are "class", "enum", "function", "import", "interface", "namespace", "typeAlias" and "typeParameter". You can also pass "underscore" to ignore variable names that begin with _. Just set the value to false for the check you want to disable. All checks default to true, i.e. are enabled by default. Note that you cannot disable variables and parameters.

      The option "temporalDeadZone" defaults to true which shows errors when shadowing block scoped declarations in their temporal dead zone. When set to false parameters, classes, enums and variables declared with let or const are not considered shadowed if the shadowing occurs within their temporal dead zone.

      The following example shows how the "temporalDeadZone" option changes the linting result:

      function fn(value) {
          if (value) {
              const tmp = value; // no error on this line if "temporalDeadZone" is false
              return tmp;
          }
          let tmp = undefined;
          if (!value) {
              const tmp = value; // this line always contains an error
              return tmp;
          }
      }
      Examples
      "no-shadowed-variable": true
      "no-shadowed-variable": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "class": {
            "type": "boolean"
          },
          "enum": {
            "type": "boolean"
          },
          "function": {
            "type": "boolean"
          },
          "import": {
            "type": "boolean"
          },
          "interface": {
            "type": "boolean"
          },
          "namespace": {
            "type": "boolean"
          },
          "typeAlias": {
            "type": "boolean"
          },
          "typeParameter": {
            "type": "boolean"
          },
          "temporalDeadZone": {
            "type": "boolean"
          },
          "underscore": {
            "type": "boolean"
          }
        }
      }

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                  var xs = config.x;
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                  var variations = [
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

          var log = config.settings.log;
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                  var propSortBy;
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                  var variantIndex = -1;
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

          var propSortBy = strategy(config);
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Identifier 'primaryY' is never reassigned; use 'const' instead of 'var'.
      Open

                  var primaryY = ys[ys.length - 1];
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Identifier 'propSortBy' is never reassigned; use 'const' instead of 'var'.
      Open

          var propSortBy = strategy(config);
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

          var config = normalizeConfig(rawConfig);
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

          var strategy = lineOrientationStrategies.hasOwnProperty(orient) ?
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Identifier 'variations' is never reassigned; use 'const' instead of 'var'.
      Open

                  var variations = [
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      Identifier 'orient' is never reassigned; use 'const' instead of 'var'.
      Open

          var orient = (config.lineOrientation || '').toLowerCase();
      Severity: Minor
      Found in src/api/chart-line.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
        "type": "object",
        "properties": {
          "destructuring": {
            "type": "string",
            "enum": [
              "all",
              "any"
            ]
          }
        }
      }

      For more information see this page.

      There are no issues that match your filters.

      Category
      Status