Sign upLogin

TargetProcess/tauCharts

View on GitHub
Star
src/scales/time.ts

Summary

Maintainability
C
1 day
Test Coverage

Function constructor has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    constructor(xSource: DataFrame, scaleConfig: ScaleConfig) {

        super(xSource, scaleConfig);

        var props = this.scaleConfig;
Severity: Minor
Found in src/scales/time.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    create(interval) {

        var varSet = this.vars;
        var utcTime = this.scaleConfig.utcTime;
        const period = this.periodGenerator;
Severity: Minor
Found in src/scales/time.ts - About 1 hr to fix

    Function constructor has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        constructor(xSource: DataFrame, scaleConfig: ScaleConfig) {

        super(xSource, scaleConfig);

        var props = this.scaleConfig;
    Severity: Minor
    Found in src/scales/time.ts - About 1 hr to fix

      Function create has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          create(interval) {

        var varSet = this.vars;
        var utcTime = this.scaleConfig.utcTime;
        const period = this.periodGenerator;
      Severity: Minor
      Found in src/scales/time.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getTimeTicks has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      function getTimeTicks(domain: Date[], utc: boolean, count = 10) {

    const d0 = Number(domain[0]);
    const d1 = Number(domain[1]);
      Severity: Minor
      Found in src/scales/time.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function getD3UtcInterval(name: string) {
    return d3[`utc${name[0].toUpperCase()}${name.slice(1)}`];
}
      Severity: Minor
      Found in src/scales/time.ts and 1 other location - About 50 mins to fix
      src/scales/time.ts on lines 152..154

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function getD3Interval(name: string) {
    return d3[`time${name[0].toUpperCase()}${name.slice(1)}`];
}
      Severity: Minor
      Found in src/scales/time.ts and 1 other location - About 50 mins to fix
      src/scales/time.ts on lines 156..158

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                  var niceInterval = props.niceInterval;
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Identifier 'props' is never reassigned; use 'const' instead of 'var'.
      Open

              var props = this.scaleConfig;
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "destructuring": {
      "type": "string",
      "enum": [
        "all",
        "any"
      ]
    }
  }
}

      For more information see this page.

      Shadowed name: 'd3Scale'
      Open

              const d3Scale = d3TimeScale()
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-shadowed-variable

      Disallows shadowing variable declarations.

      Rationale

      When a variable in a local scope and a variable in the containing scope have the same name, shadowing occurs. Shadowing makes it impossible to access the variable in the containing scope and obscures to what value an identifier actually refers. Compare the following snippets:

      const a = 'no shadow';
function print() {
    console.log(a);
}
print(); // logs 'no shadow'.
      const a = 'no shadow';
function print() {
    const a = 'shadow'; // TSLint will complain here.
    console.log(a);
}
print(); // logs 'shadow'.

      ESLint has an equivalent rule. For more background information, refer to this MDN closure doc.

      Config

      You can optionally pass an object to disable checking for certain kinds of declarations. Possible keys are "class", "enum", "function", "import", "interface", "namespace", "typeAlias" and "typeParameter". You can also pass "underscore" to ignore variable names that begin with _. Just set the value to false for the check you want to disable. All checks default to true, i.e. are enabled by default. Note that you cannot disable variables and parameters.

      The option "temporalDeadZone" defaults to true which shows errors when shadowing block scoped declarations in their temporal dead zone. When set to false parameters, classes, enums and variables declared with let or const are not considered shadowed if the shadowing occurs within their temporal dead zone.

      The following example shows how the "temporalDeadZone" option changes the linting result:

      function fn(value) {
    if (value) {
        const tmp = value; // no error on this line if "temporalDeadZone" is false
        return tmp;
    }
    let tmp = undefined;
    if (!value) {
        const tmp = value; // this line always contains an error
        return tmp;
    }
}
      Examples
      "no-shadowed-variable": true
      "no-shadowed-variable": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "class": {
      "type": "boolean"
    },
    "enum": {
      "type": "boolean"
    },
    "function": {
      "type": "boolean"
    },
    "import": {
      "type": "boolean"
    },
    "interface": {
      "type": "boolean"
    },
    "namespace": {
      "type": "boolean"
    },
    "typeAlias": {
      "type": "boolean"
    },
    "typeParameter": {
      "type": "boolean"
    },
    "temporalDeadZone": {
      "type": "boolean"
    },
    "underscore": {
      "type": "boolean"
    }
  }
}

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

              var props = this.scaleConfig;
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

              var varSet = this.vars;
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

              var x = new Date(aTime);
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Identifier 'niceInterval' is never reassigned; use 'const' instead of 'var'.
      Open

                  var niceInterval = props.niceInterval;
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "destructuring": {
      "type": "string",
      "enum": [
        "all",
        "any"
      ]
    }
  }
}

      For more information see this page.

      Identifier 'domain' is never reassigned; use 'const' instead of 'var'.
      Open

              var domain = this.domain();
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "destructuring": {
      "type": "string",
      "enum": [
        "all",
        "any"
      ]
    }
  }
}

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

              var max = domain[domain.length - 1];
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

              var utcTime = this.scaleConfig.utcTime;
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Identifier 'varSet' is never reassigned; use 'const' instead of 'var'.
      Open

              var varSet = this.vars;
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "destructuring": {
      "type": "string",
      "enum": [
        "all",
        "any"
      ]
    }
  }
}

      For more information see this page.

      Identifier 'before' is never reassigned; use 'const' instead of 'let'.
      Open

              let before = (target / intervals[i - 1].duration);
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "destructuring": {
      "type": "string",
      "enum": [
        "all",
        "any"
      ]
    }
  }
}

      For more information see this page.

      Identifier 'after' is never reassigned; use 'const' instead of 'let'.
      Open

              let after = (intervals[i].duration / target);
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "destructuring": {
      "type": "string",
      "enum": [
        "all",
        "any"
      ]
    }
  }
}

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

              var domain = this.domain();
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

              var scale = ((x) => {
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                  var max = varSet[1];
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Identifier 'min' is never reassigned; use 'const' instead of 'var'.
      Open

                  var min = varSet[0];
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "destructuring": {
      "type": "string",
      "enum": [
        "all",
        "any"
      ]
    }
  }
}

      For more information see this page.

      Use a conditional expression instead of assigning to 'this.niceIntervalFn' in multiple places.
      Open

                  if (d3TimeInterval) {
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: prefer-conditional-expression

      Recommends to use a conditional expression instead of assigning to the same thing in each branch of an if statement.

      Rationale

      This reduces duplication and can eliminate an unnecessary variable declaration.

      Config

      If check-else-if is specified, the rule also checks nested if-else-if statements.

      Examples
      "prefer-conditional-expression": true
      "prefer-conditional-expression": true,check-else-if
      Schema
      {
  "type": "string",
  "enum": [
    "check-else-if"
  ]
}

      For more information see this page.

      Identifier 'min' is never reassigned; use 'const' instead of 'var'.
      Open

              var min = domain[0];
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "destructuring": {
      "type": "string",
      "enum": [
        "all",
        "any"
      ]
    }
  }
}

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

              var min = domain[0];
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Identifier 'utcTime' is never reassigned; use 'const' instead of 'var'.
      Open

              var utcTime = this.scaleConfig.utcTime;
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "destructuring": {
      "type": "string",
      "enum": [
        "all",
        "any"
      ]
    }
  }
}

      For more information see this page.

      Shadowed name: 'i'
      Open

          const i = d3.bisector((i: SortedIntervalInfo) => i.duration).right(intervals, target);
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-shadowed-variable

      Disallows shadowing variable declarations.

      Rationale

      When a variable in a local scope and a variable in the containing scope have the same name, shadowing occurs. Shadowing makes it impossible to access the variable in the containing scope and obscures to what value an identifier actually refers. Compare the following snippets:

      const a = 'no shadow';
function print() {
    console.log(a);
}
print(); // logs 'no shadow'.
      const a = 'no shadow';
function print() {
    const a = 'shadow'; // TSLint will complain here.
    console.log(a);
}
print(); // logs 'shadow'.

      ESLint has an equivalent rule. For more background information, refer to this MDN closure doc.

      Config

      You can optionally pass an object to disable checking for certain kinds of declarations. Possible keys are "class", "enum", "function", "import", "interface", "namespace", "typeAlias" and "typeParameter". You can also pass "underscore" to ignore variable names that begin with _. Just set the value to false for the check you want to disable. All checks default to true, i.e. are enabled by default. Note that you cannot disable variables and parameters.

      The option "temporalDeadZone" defaults to true which shows errors when shadowing block scoped declarations in their temporal dead zone. When set to false parameters, classes, enums and variables declared with let or const are not considered shadowed if the shadowing occurs within their temporal dead zone.

      The following example shows how the "temporalDeadZone" option changes the linting result:

      function fn(value) {
    if (value) {
        const tmp = value; // no error on this line if "temporalDeadZone" is false
        return tmp;
    }
    let tmp = undefined;
    if (!value) {
        const tmp = value; // this line always contains an error
        return tmp;
    }
}
      Examples
      "no-shadowed-variable": true
      "no-shadowed-variable": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "class": {
      "type": "boolean"
    },
    "enum": {
      "type": "boolean"
    },
    "function": {
      "type": "boolean"
    },
    "import": {
      "type": "boolean"
    },
    "interface": {
      "type": "boolean"
    },
    "namespace": {
      "type": "boolean"
    },
    "typeAlias": {
      "type": "boolean"
    },
    "typeParameter": {
      "type": "boolean"
    },
    "temporalDeadZone": {
      "type": "boolean"
    },
    "underscore": {
      "type": "boolean"
    }
  }
}

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                  var d3TimeInterval = (niceInterval && getD3Interval(niceInterval) ?
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Shadowed name: 'time'
      Open

          const info = (time: IntervalInfo, step: number) => {
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-shadowed-variable

      Disallows shadowing variable declarations.

      Rationale

      When a variable in a local scope and a variable in the containing scope have the same name, shadowing occurs. Shadowing makes it impossible to access the variable in the containing scope and obscures to what value an identifier actually refers. Compare the following snippets:

      const a = 'no shadow';
function print() {
    console.log(a);
}
print(); // logs 'no shadow'.
      const a = 'no shadow';
function print() {
    const a = 'shadow'; // TSLint will complain here.
    console.log(a);
}
print(); // logs 'shadow'.

      ESLint has an equivalent rule. For more background information, refer to this MDN closure doc.

      Config

      You can optionally pass an object to disable checking for certain kinds of declarations. Possible keys are "class", "enum", "function", "import", "interface", "namespace", "typeAlias" and "typeParameter". You can also pass "underscore" to ignore variable names that begin with _. Just set the value to false for the check you want to disable. All checks default to true, i.e. are enabled by default. Note that you cannot disable variables and parameters.

      The option "temporalDeadZone" defaults to true which shows errors when shadowing block scoped declarations in their temporal dead zone. When set to false parameters, classes, enums and variables declared with let or const are not considered shadowed if the shadowing occurs within their temporal dead zone.

      The following example shows how the "temporalDeadZone" option changes the linting result:

      function fn(value) {
    if (value) {
        const tmp = value; // no error on this line if "temporalDeadZone" is false
        return tmp;
    }
    let tmp = undefined;
    if (!value) {
        const tmp = value; // this line always contains an error
        return tmp;
    }
}
      Examples
      "no-shadowed-variable": true
      "no-shadowed-variable": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "class": {
      "type": "boolean"
    },
    "enum": {
      "type": "boolean"
    },
    "function": {
      "type": "boolean"
    },
    "import": {
      "type": "boolean"
    },
    "interface": {
      "type": "boolean"
    },
    "namespace": {
      "type": "boolean"
    },
    "typeAlias": {
      "type": "boolean"
    },
    "typeParameter": {
      "type": "boolean"
    },
    "temporalDeadZone": {
      "type": "boolean"
    },
    "underscore": {
      "type": "boolean"
    }
  }
}

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

              var vars = this.vars;
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

                  var min = varSet[0];
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

          var step: number;
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

              var d3TimeScale = (utcTime ? d3.scaleUtc : d3.scaleTime);
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Forbidden 'var' keyword, use 'let' or 'const' instead
      Open

          var interval: d3.CountableTimeInterval;
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: no-var-keyword

      Disallows usage of the var keyword.

      Use let or const instead.

      Rationale

      Declaring variables using var has several edge case behaviors that make var unsuitable for modern code. Variables declared by var have their parent function block as their scope, ignoring other control flow statements. vars have declaration "hoisting" (similar to functions) and can appear to be used before declaration.

      Variables declared by const and let instead have as their scope the block in which they are defined, and are not allowed to used before declaration or be re-declared with another const or let.

      Notes
      • Has Fix

      Config

      Not configurable.

      Examples
      "no-var-keyword": true

      For more information see this page.

      Identifier 'ti' is never reassigned; use 'const' instead of 'let'.
      Open

              let ti = intervals[before < after ? i - 1 : i];
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "destructuring": {
      "type": "string",
      "enum": [
        "all",
        "any"
      ]
    }
  }
}

      For more information see this page.

      Identifier 'mid' is never reassigned; use 'const' instead of 'let'.
      Open

                  let mid = this.vars[0];
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "destructuring": {
      "type": "string",
      "enum": [
        "all",
        "any"
      ]
    }
  }
}

      For more information see this page.

      Identifier 'd3TimeInterval' is never reassigned; use 'const' instead of 'var'.
      Open

                  var d3TimeInterval = (niceInterval && getD3Interval(niceInterval) ?
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "destructuring": {
      "type": "string",
      "enum": [
        "all",
        "any"
      ]
    }
  }
}

      For more information see this page.

      Identifier 'max' is never reassigned; use 'const' instead of 'var'.
      Open

              var max = domain[domain.length - 1];
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "destructuring": {
      "type": "string",
      "enum": [
        "all",
        "any"
      ]
    }
  }
}

      For more information see this page.

      Identifier 'max' is never reassigned; use 'const' instead of 'var'.
      Open

                  var max = varSet[1];
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "destructuring": {
      "type": "string",
      "enum": [
        "all",
        "any"
      ]
    }
  }
}

      For more information see this page.

      Identifier 'd3TimeScale' is never reassigned; use 'const' instead of 'var'.
      Open

              var d3TimeScale = (utcTime ? d3.scaleUtc : d3.scaleTime);
      Severity: Minor
      Found in src/scales/time.ts by tslint

      Rule: prefer-const

      Requires that variable declarations use const instead of let and var if possible.

      If a variable is only assigned to once when it is declared, it should be declared using 'const'

      Notes
      • Has Fix

      Config

      An optional object containing the property "destructuring" with two possible values:

      • "any" (default) - If any variable in destructuring can be const, this rule warns for those variables.
      • "all" - Only warns if all variables in destructuring can be const.
      Examples
      "prefer-const": true
      "prefer-const": true,[object Object]
      Schema
      {
  "type": "object",
  "properties": {
    "destructuring": {
      "type": "string",
      "enum": [
        "all",
        "any"
      ]
    }
  }
}

      For more information see this page.

      There are no issues that match your filters.

      Category
      Status