Sign upLogin

TeaWithStrangers/tws-on-rails

View on GitHub
Star
app/controllers/attendance_controller.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method create has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def create
    @user = current_user
    @tea_time = TeaTime.find(params[:id])

    @attendance = Attendance.where(tea_time_id: @tea_time.id, user_id: @user.id).first_or_initialize
Severity: Minor
Found in app/controllers/attendance_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method mark has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def mark
    @tea_time = TeaTime.find(params[:id])
    respond_to do |format|
      case params[:marking]
      when 'email'
Severity: Minor
Found in app/controllers/attendance_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method mark has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def mark
    @tea_time = TeaTime.find(params[:id])
    respond_to do |format|
      case params[:marking]
      when 'email'
Severity: Minor
Found in app/controllers/attendance_controller.rb - About 1 hr to fix

    Method create has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def create
    @user = current_user
    @tea_time = TeaTime.find(params[:id])

    @attendance = Attendance.where(tea_time_id: @tea_time.id, user_id: @user.id).first_or_initialize
    Severity: Minor
    Found in app/controllers/attendance_controller.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status