TeaWithStrangers/tws-on-rails

View on GitHub
app/models/user.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class User has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

class User < ActiveRecord::Base
  acts_as_paranoid

  # Include default devise modules. Others available are:
  # :confirmable, :lockable, :timeoutable and :omniauthable
Severity: Minor
Found in app/models/user.rb - About 3 hrs to fix

    Method commitment_overview= has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def commitment_overview=(overview)
        if overview.to_s != HostDetail::REGULAR_COMMITMENT.to_s
          if commitment.nil?
            if overview.to_s == HostDetail::NO_COMMITMENT.to_s
              HostMailer.commitment_intro(id).deliver_later
    Severity: Minor
    Found in app/models/user.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status