Sign upLogin

Terralego/django-geostore

View on GitHub
Star
geostore/import_export/imports.py

Summary

Maintainability
B
4 hrs
Test Coverage

Cyclomatic complexity is too high in method from_shapefile. (7)
Open

    @zoom_update
    def from_shapefile(self, zipped_shapefile_file, id_field=None):
        """ Load ShapeFile content provided into a zipped archive.

        zipped_shapefile_file -- a file-like object on the zipped content
Severity: Minor
Found in geostore/import_export/imports.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function from_csv_dictreader has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def from_csv_dictreader(self, reader, pk_properties, options, operations,
Severity: Major
Found in geostore/import_export/imports.py - About 1 hr to fix

    Function _initial_import_from_csv has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def _initial_import_from_csv(self, chunks, options, operations):
        for chunk in chunks:
            entries = []
            for row in chunk:
                feature_args = {
    Severity: Minor
    Found in geostore/import_export/imports.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function from_shapefile has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def from_shapefile(self, zipped_shapefile_file, id_field=None):
        """ Load ShapeFile content provided into a zipped archive.

        zipped_shapefile_file -- a file-like object on the zipped content
        id_field -- the field name used a identifier
    Severity: Minor
    Found in geostore/import_export/imports.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _complementary_import_from_csv has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def _complementary_import_from_csv(self, chunks, options, operations,
    Severity: Minor
    Found in geostore/import_export/imports.py - About 45 mins to fix

      Function _import_row_from_csv has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def _import_row_from_csv(self, row, pk_properties, operations, options):
      Severity: Minor
      Found in geostore/import_export/imports.py - About 35 mins to fix

        Method "from_csv_dictreader" has 8 parameters, which is greater than the 7 authorized.
        Open

            def from_csv_dictreader(self, reader, pk_properties, options, operations,
                            init=False, chunk_size=1000, fast=False):
        Severity: Major
        Found in geostore/import_export/imports.py by sonar-python

        A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

        Noncompliant Code Example

        With a maximum number of 4 parameters:

        def do_something(param1, param2, param3, param4, param5):
    ...

        Compliant Solution

        def do_something(param1, param2, param3, param4):
    ...

        There are no issues that match your filters.

        Category
        Status