Terralego/django-geostore

View on GitHub
geostore/tiles/helpers.py

Summary

Maintainability
A
1 hr
Test Coverage

Standard pseudo-random generators are not suitable for security/cryptographic purposes.
Open

        expiration = int(expiration_factor * (3600 * 24 * 7) * uniform(0.9, 1.1))
Severity: Info
Found in geostore/tiles/helpers.py by bandit

Cyclomatic complexity is too high in method get_tile. (7)
Open

    @cached_tile
    def get_tile(self, x, y, z, name=None, features_pks=None):
        xmin, ymin, xmax, ymax = self.get_tile_bbox(x, y, z)
        pixel_width_x, pixel_width_y = self.pixel_widths(xmin, ymin, xmax, ymax)

Severity: Minor
Found in geostore/tiles/helpers.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function wrapper has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def wrapper(self, x, y, z,
Severity: Minor
Found in geostore/tiles/helpers.py - About 45 mins to fix

    Function get_tile has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def get_tile(self, x, y, z, name=None, features_pks=None):
    Severity: Minor
    Found in geostore/tiles/helpers.py - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status