Sign upLogin

Terralego/django-geostore

View on GitHub
Star
geostore/views/__init__.py

Summary

Maintainability
A
3 hrs
Test Coverage

File __init__.py has 259 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import json
from copy import deepcopy

from django.contrib.gis.gdal.error import GDALException
from django.contrib.gis.geos import GEOSException, GEOSGeometry
Severity: Minor
Found in geostore/views/__init__.py - About 2 hrs to fix

    Cyclomatic complexity is too high in method extra_geometry. (6)
    Open

        @action(detail=True, methods=['get', 'put', 'patch', 'delete'],
            url_path=r'extra_geometry/(?P<id_extra_feature>\d+)', url_name='detail-extra-geometry')
    def extra_geometry(self, request, id_extra_feature, *args, **kwargs):
        feature = self.get_object()
        extra_geometry = get_object_or_404(feature.extra_geometries.all(), pk=id_extra_feature)
    Severity: Minor
    Found in geostore/views/__init__.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function extra_geometry has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def extra_geometry(self, request, id_extra_feature, *args, **kwargs):
    Severity: Minor
    Found in geostore/views/__init__.py - About 35 mins to fix

      Function extra_layer_geometry has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def extra_layer_geometry(self, request, id_extra_layer, *args, **kwargs):
      Severity: Minor
      Found in geostore/views/__init__.py - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status