Terralego/django-template-engines

View on GitHub
template_engines/templatetags/utils.py

Summary

Maintainability
A
1 hr
Test Coverage

Audit url open for permitted schemes. Allowing use of file:/ or custom schemes is often unexpected.
Open

    file = urlopen(uri)

Function get_image_infos_from_uri has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def get_image_infos_from_uri(uri):
    """ get image size and dimensions """
    if not uri.lower().startswith('http'):
        # protect use of urlopen from filesystem read
        return None, (None, None), None
Severity: Minor
Found in template_engines/templatetags/utils.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function resize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def resize(bimage, max_width, max_height, odt=True):
    """
    Resize the image with max_width or/and max_height has been specified,
    otherwise convert them.

Severity: Minor
Found in template_engines/templatetags/utils.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status