Showing 27 of 34 total issues
Function grouped_form_schema has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def grouped_form_schema(self):
original_schema = deepcopy(self.layer.schema)
generated_schema = deepcopy(original_schema)
groups = self.feature_display_groups.all()
generated_schema['properties'] = {}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function validate_properties has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def validate_properties(self, data):
new_data = deepcopy(data)
# ungroup properties
for key, value in new_data.items():
if isinstance(value, dict):- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function generate_thumbnail_from_image has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def generate_thumbnail_from_image(value, data, data_type):
# generate / get thumbnail for image
if not value:
return data, data_type
try:- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function sync_properties_relations_destination has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def sync_properties_relations_destination(feature, update_relations=False):
for relation_destination in feature.layer.relations_as_destination.all():
for feature in relation_destination.origin.features.all():
if update_relations:
feature.sync_relations(relation_destination.pk)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function get_map_layers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def get_map_layers(self, obj):
data = [{
'title': obj.name,
# TODO: Add slugify to be consistent with relations
'id_layer_vt': obj.layer.name,- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Use of insecure MD2, MD4, MD5, or SHA1 hash function. Open
options['hash'] = hashlib.md5(source_image.tobytes()).hexdigest()- Exclude checks
Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed. Open
def get_thumbnail(self, file_, geometry_string, **options):- Read upRead up
- Exclude checks
Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.