Sign upLogin

Terralego/django-terra-geocrud

View on GitHub
Star
terra_geocrud/serializers.py

Summary

Maintainability
A
50 mins
Test Coverage

File serializers.py has 405 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

import json
from collections import OrderedDict
from copy import deepcopy
from pathlib import Path
Severity: Minor
Found in terra_geocrud/serializers.py - About 5 hrs to fix

    Function validate_properties has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def validate_properties(self, data):
        new_data = deepcopy(data)
        # ungroup properties
        for key, value in new_data.items():
            if isinstance(value, dict):
    Severity: Minor
    Found in terra_geocrud/serializers.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_map_layers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_map_layers(self, obj):
        data = [{
            'title': obj.name,
            # TODO: Add slugify to be consistent with relations
            'id_layer_vt': obj.layer.name,
    Severity: Minor
    Found in terra_geocrud/serializers.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status