TestingResearchIllinois/NonDex

View on GitHub
nondex-gradle-plugin/plugin/src/main/java/edu/illinois/nondex/gradle/tasks/NonDexDebug.java

Summary

Maintainability
D
2 days
Test Coverage

File NonDexDebug.java has 289 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package edu.illinois.nondex.gradle.tasks;

import com.google.common.collect.LinkedListMultimap;
import edu.illinois.nondex.common.Configuration;
import edu.illinois.nondex.common.ConfigurationDefaults;

    Method startDebugLinear has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

            private List<Configuration> startDebugLinear(Configuration config, long start, long end) {
                List<Configuration> allFailingConfigurations = new LinkedList<>();
    
                List<Pair<Pair<Long, Long>, Configuration>> pairs = new LinkedList<>();
                pairs.add(Pair.of(Pair.of(start, end),

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method startDebugBinary has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

            private List<Configuration> startDebugBinary(Configuration config) {
                List<Configuration> allFailingConfigurations = new LinkedList<>();
    
                List<Pair<Pair<Long, Long>, Configuration>> pairs = new LinkedList<>();
                pairs.add(Pair.of(Pair.of(0L, (long) config.getInvocationCount()), config));

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method startDebugLinear has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            private List<Configuration> startDebugLinear(Configuration config, long start, long end) {
                List<Configuration> allFailingConfigurations = new LinkedList<>();
    
                List<Pair<Pair<Long, Long>, Configuration>> pairs = new LinkedList<>();
                pairs.add(Pair.of(Pair.of(start, end),

      Method startDebugBinary has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              private List<Configuration> startDebugBinary(Configuration config) {
                  List<Configuration> allFailingConfigurations = new LinkedList<>();
      
                  List<Pair<Pair<Long, Long>, Configuration>> pairs = new LinkedList<>();
                  pairs.add(Pair.of(Pair.of(0L, (long) config.getInvocationCount()), config));

        Method debug has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

                private String debug() {
                    if (this.failingConfigurations.isEmpty()) {
                        throw new RuntimeException("Tests need to first fail with NonDex to be debugged");
                    }
        
        

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                private List<Configuration> createNewSeedsToRetry() {
                    Configuration someFailingConfig = this.failingConfigurations.iterator().next();
                    int newSeed = someFailingConfig.seed * ConfigurationDefaults.SEED_FACTOR;
                    List<Configuration> retryWithOtherSeeds = new LinkedList<>();
                    for (int i = 0; i < 10; i++) {
        nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java on lines 134..148

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 127.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                private String makeResultString(List<Configuration> debuggedOnes) {
                    StringBuilder sb = new StringBuilder();
                    for (Configuration config : debuggedOnes) {
                        if (config == null) {
                            continue;
        nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java on lines 116..132

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 112.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                private String tryDebugSeeds() {
                    List<Configuration> debuggedOnes = this.debugWithConfigurations(this.failingConfigurations);
        
                    if (debuggedOnes.size() > 0) {
                        return makeResultString(debuggedOnes);
        nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java on lines 96..114

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                private List<Configuration> debugWithConfigurations(List<Configuration> failingConfigurations) {
                    List<Configuration> allDebuggedConfigs = new LinkedList<>();
                    for (Configuration config : failingConfigurations) {
                        Configuration dryConfig;
                        if ((dryConfig = this.failsOnDry(config)) != null) {
        nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java on lines 150..162

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 72.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                try (BufferedReader br = new BufferedReader(new FileReader(run))) {
                    String line;
                    while ((line = br.readLine()) != null) {
                        this.executions.add(line.trim());
                    }
        nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugMojo.java on lines 121..128

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                            if ((failingConfiguration = this.failsWithConfig(config, localStart + 1, localEnd)) != null) {
                                pairs.add(Pair.of(Pair.of(localStart + 1, localEnd), failingConfiguration));
                                found = true;
                            }
        nondex-gradle-plugin/plugin/src/main/java/edu/illinois/nondex/gradle/tasks/NonDexDebug.java on lines 260..263

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                            if ((failingConfiguration = this.failsWithConfig(config, midPoint + 1, end)) != null) {
                                pairs.add(Pair.of(Pair.of(midPoint + 1, end), failingConfiguration));
                                binarySuccess = true;
                            }
        nondex-gradle-plugin/plugin/src/main/java/edu/illinois/nondex/gradle/tasks/NonDexDebug.java on lines 309..312

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            private DebugExecuter createNondexDebugExecuter() {
                try {
                    Method getExecuter = Test.class.getDeclaredMethod("createTestExecuter");
                    getExecuter.setAccessible(true);
                    TestExecuter<JvmTestExecutionSpec> delegate = (TestExecuter<JvmTestExecutionSpec>) getExecuter.invoke(this);
        nondex-gradle-plugin/plugin/src/main/java/edu/illinois/nondex/gradle/tasks/NonDexTest.java on lines 29..38

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            private void setNondexDebugAsTestExecuter(DebugExecuter nondexDebugExecuter) {
                try {
                    Method setTestExecuter = Test.class.getDeclaredMethod("setTestExecuter", TestExecuter.class);
                    setTestExecuter.setAccessible(true);
                    setTestExecuter.invoke(this, nondexDebugExecuter);
        nondex-gradle-plugin/plugin/src/main/java/edu/illinois/nondex/gradle/tasks/NonDexTest.java on lines 40..48

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status