Sign upLogin

TestingResearchIllinois/NonDex

View on GitHub
Star
nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java

Summary

Maintainability
D
1 day
Test Coverage

Method startDebugLinear has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public List<Configuration> startDebugLinear(Configuration config, long start, long end) {
        List<Configuration> allFailingConfigurations = new LinkedList<Configuration>();

        List<Pair<Pair<Long, Long>, Configuration>> pairs = new LinkedList<Pair<Pair<Long, Long>, Configuration>>();
        pairs.add((Pair<Pair<Long, Long>, Configuration>)Pair.of((Pair<Long, Long>)Pair.of(start, end),
Severity: Minor
Found in nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method startDebugBinary has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public List<Configuration> startDebugBinary(Configuration config) {
        List<Configuration> allFailingConfigurations = new LinkedList<Configuration>();

        List<Pair<Pair<Long, Long>, Configuration>> pairs = new LinkedList<Pair<Pair<Long, Long>, Configuration>>();
        pairs.add((Pair<Pair<Long, Long>, Configuration>)Pair.of((Pair<Long, Long>)Pair.of(0L,
Severity: Minor
Found in nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method startDebugLinear has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public List<Configuration> startDebugLinear(Configuration config, long start, long end) {
        List<Configuration> allFailingConfigurations = new LinkedList<Configuration>();

        List<Pair<Pair<Long, Long>, Configuration>> pairs = new LinkedList<Pair<Pair<Long, Long>, Configuration>>();
        pairs.add((Pair<Pair<Long, Long>, Configuration>)Pair.of((Pair<Long, Long>)Pair.of(start, end),
Severity: Minor
Found in nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java - About 1 hr to fix

    Method startDebugBinary has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public List<Configuration> startDebugBinary(Configuration config) {
        List<Configuration> allFailingConfigurations = new LinkedList<Configuration>();

        List<Pair<Pair<Long, Long>, Configuration>> pairs = new LinkedList<Pair<Pair<Long, Long>, Configuration>>();
        pairs.add((Pair<Pair<Long, Long>, Configuration>)Pair.of((Pair<Long, Long>)Pair.of(0L,
    Severity: Minor
    Found in nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java - About 1 hr to fix

      Method debug has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public String debug() throws MojoExecutionException {

        //The test must have failed if it's being debugged, ergo there should exist a failing configuration
        assert (!this.failingConfigurations.isEmpty());
      Severity: Minor
      Found in nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      TODO found
      Open

              // TODO(gyori): refactor this crap.
      Severity: Minor
      Found in nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java by fixme

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private List<Configuration> createNewSeedsToRetry() {
        Configuration someFailingConfig = this.failingConfigurations.iterator().next();
        int newSeed = someFailingConfig.seed * ConfigurationDefaults.SEED_FACTOR;
        List<Configuration> retryWOtherSeeds = new LinkedList<>();
        for (int i = 0; i < 10; i++) {
      Severity: Major
      Found in nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java and 1 other location - About 1 hr to fix
      nondex-gradle-plugin/plugin/src/main/java/edu/illinois/nondex/gradle/tasks/NonDexDebug.java on lines 203..217

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 127.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private String makeResultString(List<Configuration> debuggedOnes) {
        StringBuilder sb = new StringBuilder();
        for (Configuration config : debuggedOnes) {
            if (config == null) {
                continue;
      Severity: Major
      Found in nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java and 1 other location - About 1 hr to fix
      nondex-gradle-plugin/plugin/src/main/java/edu/illinois/nondex/gradle/tasks/NonDexDebug.java on lines 185..201

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 112.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private String tryDebugSeeds() {
        List<Configuration> debuggedOnes = this.debugWithConfigurations(this.failingConfigurations);

        if (debuggedOnes.size() > 0) {
            return makeResultString(debuggedOnes);
      Severity: Major
      Found in nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java and 1 other location - About 1 hr to fix
      nondex-gradle-plugin/plugin/src/main/java/edu/illinois/nondex/gradle/tasks/NonDexDebug.java on lines 165..183

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private List<Configuration> debugWithConfigurations(List<Configuration> failingConfigurations) {
        List<Configuration> allDebuggedConfigs = new LinkedList<Configuration>();
        for (Configuration config : failingConfigurations) {
            Configuration dryConfig;
            if ((dryConfig = this.failsOnDry(config)) != null) {
      Severity: Major
      Found in nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java and 1 other location - About 1 hr to fix
      nondex-gradle-plugin/plugin/src/main/java/edu/illinois/nondex/gradle/tasks/NonDexDebug.java on lines 219..231

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                      if ((failingConfiguration = this.failsWithConfig(config, midPoint + 1, end)) != null) {
                    pairs.add(Pair.of((Pair<Long, Long>)Pair.of(midPoint + 1, end), failingConfiguration));
                    binarySuccess = true;
                }
      Severity: Minor
      Found in nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java and 1 other location - About 50 mins to fix
      nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java on lines 241..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                      if ((failingConfiguration = this.failsWithConfig(config, localStart + 1, localEnd)) != null) {
                    pairs.add(Pair.of((Pair<Long, Long>)Pair.of(localStart + 1, localEnd), failingConfiguration));
                    found = true;
                }
      Severity: Minor
      Found in nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java and 1 other location - About 50 mins to fix
      nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java on lines 192..195

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status