TheCorrespondingSquares/chess-app

View on GitHub
app/models/concerns/squares.rb

Summary

Maintainability
A
0 mins
Test Coverage

Carriage return character detected.
Open

module Squares
  include Movements
Severity: Minor
Found in app/models/concerns/squares.rb by rubocop

Extra empty line detected at module body end.
Open


end
Severity: Minor
Found in app/models/concerns/squares.rb by rubocop

This cops checks if empty lines around the bodies of modules match the configuration.

Example: EnforcedStyle: empty_lines

# good

module Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

module Foo
  module Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
module Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

module Foo
  def bar
    # ...
  end
end

Trailing whitespace detected.
Open

  
Severity: Minor
Found in app/models/concerns/squares.rb by rubocop

Redundant self detected.
Open

    pieces = Piece.where(game_id: self.game_id)
Severity: Minor
Found in app/models/concerns/squares.rb by rubocop

This cop checks for redundant uses of self.

The usage of self is only needed when:

  • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

  • Calling an attribute writer to prevent an local variable assignment.

Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

Note we allow uses of self with operators because it would be awkward otherwise.

Example:

# bad
def foo(bar)
  self.baz
end

# good
def foo(bar)
  self.bar  # Resolves name clash with the argument.
end

def foo
  bar = 1
  self.bar  # Resolves name clash with the local variable.
end

def foo
  %w[x y z].select do |bar|
    self.bar == bar  # Resolves name clash with argument of the block.
  end
end

Final newline missing.
Open

end
Severity: Minor
Found in app/models/concerns/squares.rb by rubocop

Rename is_on_square? to on_square?.
Open

  def is_on_square?(x, y)
Severity: Minor
Found in app/models/concerns/squares.rb by rubocop

This cop makes sure that predicates are named properly.

Example:

# bad
def is_even?(value)
end

# good
def even?(value)
end

# bad
def has_value?
end

# good
def value?
end

Missing top-level module documentation comment.
Open

module Squares
Severity: Minor
Found in app/models/concerns/squares.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

There are no issues that match your filters.

Category
Status