TheCorrespondingSquares/chess-app

View on GitHub
app/services/check_mate.rb

Summary

Maintainability
A
55 mins
Test Coverage

Method has too many lines. [15/10]
Open

  def king_can_be_blocked?

    obstruction_path = []
    starting_x = @piece_making_check.x_pos
    starting_y = @piece_making_check.y_pos
Severity: Minor
Found in app/services/check_mate.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for king_can_be_blocked? is too high. [18.49/15]
Open

  def king_can_be_blocked?

    obstruction_path = []
    starting_x = @piece_making_check.x_pos
    starting_y = @piece_making_check.y_pos
Severity: Minor
Found in app/services/check_mate.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method king_can_be_blocked? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def king_can_be_blocked?

    obstruction_path = []
    starting_x = @piece_making_check.x_pos
    starting_y = @piece_making_check.y_pos
Severity: Minor
Found in app/services/check_mate.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Extra empty line detected at class body end.
Open


end
Severity: Minor
Found in app/services/check_mate.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Missing top-level class documentation comment.
Open

class CheckMate
Severity: Minor
Found in app/services/check_mate.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Extra empty line detected at method body beginning.
Open


    obstruction_path = []
Severity: Minor
Found in app/services/check_mate.rb by rubocop

This cops checks if empty lines exist around the bodies of methods.

Example:

# good

def foo
  # ...
end

# bad

def bar

  # ...

end

Final newline missing.
Open

end
Severity: Minor
Found in app/services/check_mate.rb by rubocop

Line is too long. [100/80]
Open

    return false if king_can_be_blocked? || king_can_capture_piece? || king.is_able_to_escape_check?
Severity: Minor
Found in app/services/check_mate.rb by rubocop

Line is too long. [87/80]
Open

    @opposite_pieces = @game.pieces.where(captured: false).where.not(color: king_color)
Severity: Minor
Found in app/services/check_mate.rb by rubocop

Line is too long. [83/80]
Open

    @friendly_pieces = @game.pieces.where(captured: false).where(color: king_color)
Severity: Minor
Found in app/services/check_mate.rb by rubocop

There are no issues that match your filters.

Category
Status