Sign upLogin

TheCorrespondingSquares/chess-app

View on GitHub
Star

Showing 927 of 927 total issues

Trailing whitespace detected.
Open

        redirect_to game_path(piece.game)
Severity: Minor
Found in app/controllers/pieces_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

    if !current_game_player?
Severity: Minor
Found in app/controllers/pieces_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

          flash[:alert] = "Sorry, that move would leave your King in check."
Severity: Minor
Found in app/controllers/pieces_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use nested module/class definitions instead of compact style.
Open

class Users::OmniauthCallbacksController < Devise::OmniauthCallbacksController
Severity: Minor
Found in app/controllers/users/omniauth_callbacks_controller.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Line is too long. [92/80]
Open

    params.require(:game).permit(:name, :user_id, :white_player_id, :black_player_id, :turn)
Severity: Minor
Found in app/controllers/games_controller.rb by rubocop

Extra empty line detected at method body beginning.
Open


    obstruction_path = []
Severity: Minor
Found in app/services/check_mate.rb by rubocop

This cops checks if empty lines exist around the bodies of methods.

Example:

# good

def foo
  # ...
end

# bad

def bar

  # ...

end

Line is too long. [81/80]
Open

# incrementally modify your database, and then regenerate this schema definition.
Severity: Minor
Found in db/schema.rb by rubocop

Line is too long. [86/80]
Open

# from scratch. The latter is a flawed and unsustainable approach (the more migrations
Severity: Minor
Found in db/schema.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    t.index ["black_player_id"], name: "index_games_on_black_player_id", using: :btree
Severity: Minor
Found in db/schema.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    t.integer  "sign_in_count",          default: 0,  null: false
Severity: Minor
Found in db/schema.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    t.inet     "last_sign_in_ip"
Severity: Minor
Found in db/schema.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Missing top-level class documentation comment.
Open

class AddNameToGames < ActiveRecord::Migration[5.0]
Severity: Minor
Found in db/migrate/20170522184528_add_name_to_games.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Tab detected.
Open

      add_foreign_key :games, :users, column: :white_player_id
Severity: Minor
Found in db/migrate/20170529093515_add_reference_to_white_player.rb by rubocop

Missing top-level class documentation comment.
Open

class AddIconToPiece < ActiveRecord::Migration[5.0]
Severity: Minor
Found in db/migrate/20170604152306_add_icon_to_piece.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use 2 (not 1) spaces for indentation.
Open

      remove_column :games, :white_player, :integer
Severity: Minor
Found in db/migrate/20170530134636_remove_player_from_games.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Line is too long. [85/80]
Open

    subject(:bishop_valid_move?) { bishop.valid_move?(destination_x, destination_y) }
Severity: Minor
Found in spec/models/bishop_spec.rb by rubocop

Missing top-level class documentation comment.
Open

class Bishop < Piece
Severity: Minor
Found in app/models/bishop.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Trailing whitespace detected.
Open
Severity: Minor
Found in app/controllers/pieces_controller.rb by rubocop

Trailing whitespace detected.
Open

    white_piece_turn? && white_player? && white_piece?
Severity: Minor
Found in app/controllers/pieces_controller.rb by rubocop

Use 2 (not 3) spaces for indentation.
Open

       @black_player = User.find(@game.black_player_id)
Severity: Minor
Found in app/controllers/games_controller.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end
Severity
Category
Status
Source
Language