Sign upLogin

TheCorrespondingSquares/chess-app

View on GitHub
Star
spec/controllers/games_controller_spec.rb

Summary

Maintainability
A
0 mins
Test Coverage

Block has too many lines. [42/25]
Open

RSpec.describe GamesController, type: :controller do
  describe 'games#index action' do
    it 'should successfully show the page' do
      get :index
      expect(response).to have_http_status(:success)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [34/25]
Open

  describe 'games#show action' do
      let!(:user) { FactoryGirl.create(:user) }
    let!(:user2) { FactoryGirl.create(:user) }
      let!(:game) { FactoryGirl.create(:game, white_player_id: user.id, black_player_id: user2.id) }
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Tab detected.
Open

          expect(response).to have_http_status(:success)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Tab detected.
Open

      it 'should return the number and the correct piece' do
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Tab detected.
Open

          @pieces = game.pieces
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Tab detected.
Open

          get :show, params: { id: game.id }
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Inconsistent indentation detected.
Open

    it 'should update the result the winner is White and notify the game is over' do
      game.pieces.destroy_all
      game.pieces.create(name: "King", color: "White", x_pos: 7, y_pos: 7)
      game.pieces.create(name: "King", color: "Black", x_pos: 7, y_pos: 4)
      game.pieces.create(name: "Bishop", color: "Black", x_pos: 4, y_pos: 4)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Tab detected.
Open
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Trailing whitespace detected.
Open
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Tab detected.
Open

      let!(:user) { FactoryGirl.create(:user) }
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Tab detected.
Open

      end
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Use 2 (not 1) spaces for indentation.
Open

      let!(:user) { FactoryGirl.create(:user) }
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 1) spaces for indentation.
Open

          get :show, params: { id: game.id }
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Tab detected.
Open

      let!(:game) { FactoryGirl.create(:game, white_player_id: user.id, black_player_id: user2.id) }
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Inconsistent indentation detected.
Open

    let!(:user2) { FactoryGirl.create(:user) }
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Tab detected.
Open

      it 'should successfully show the page of the game' do
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Tab detected.
Open

          expect(@pieces.count).to eq 32
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Inconsistent indentation detected.
Open

    it 'should update the result the winner is Black and notify the game is over' do
      game.pieces.destroy_all
      game.pieces.create(name: "King", color: "Black", x_pos: 0, y_pos: 0)
      game.pieces.create(name: "Bishop", color: "White", x_pos: 4, y_pos: 4)
      game.pieces.create(name: "Bishop", color: "Black", x_pos: 0, y_pos: 1)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Use 2 (not 1) spaces for indentation.
Open

          get :show, params: { id: game.id }
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Tab detected.
Open

          get :show, params: { id: game.id }
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Tab detected.
Open

      end
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Line is too long. [84/80]
Open

    it 'should update the result the winner is White and notify the game is over' do
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "King", color: "Black", x_pos: 7, y_pos: 4)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "Bishop", color: "Black", x_pos: 0, y_pos: 1)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "King", color: "Black", x_pos: 0, y_pos: 0)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "Bishop", color: "White", x_pos: 4, y_pos: 4)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "King", color: "White", x_pos: 7, y_pos: 7)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "Bishop", color: "Black", x_pos: 4, y_pos: 4)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "King", color: "Black", x_pos: 7, y_pos: 4)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "Bishop", color: "Black", x_pos: 0, y_pos: 1)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "Bishop", color: "Black", x_pos: 1, y_pos: 0)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [97/80]
Open

      let!(:game) { FactoryGirl.create(:game, white_player_id: user.id, black_player_id: user2.id) }
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Line is too long. [84/80]
Open

    it 'should update the result the winner is Black and notify the game is over' do
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "Bishop", color: "White", x_pos: 7, y_pos: 6)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "King", color: "Black", x_pos: 0, y_pos: 0)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "King", color: "White", x_pos: 7, y_pos: 4)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "Bishop", color: "Black", x_pos: 1, y_pos: 0)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "King", color: "White", x_pos: 7, y_pos: 4)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Trailing whitespace detected.
Open

  end
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "King", color: "White", x_pos: 7, y_pos: 7)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "Bishop", color: "Black", x_pos: 4, y_pos: 4)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "Bishop", color: "White", x_pos: 6, y_pos: 7)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "Bishop", color: "White", x_pos: 4, y_pos: 4)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "Bishop", color: "White", x_pos: 6, y_pos: 7)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      game.pieces.create(name: "Bishop", color: "White", x_pos: 7, y_pos: 6)
Severity: Minor
Found in spec/controllers/games_controller_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

There are no issues that match your filters.

Category
Status