TheCorrespondingSquares/chess-app

Block has too many lines. [188/25]

Open

RSpec.describe PiecesController, type: :controller do
  let(:white_player) { FactoryGirl.create(:user) }
  let(:black_player) { FactoryGirl.create(:user) }
  let(:game) { FactoryGirl.create(:game, white_player_id: white_player.id, black_player_id: black_player.id) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Block has too many lines. [175/25]

Open

  describe 'pieces#update action' do
    
    context 'When a piece making a check' do
      before(:each) { game.pieces.destroy_all } 
      let!(:white_bishop) { FactoryGirl.create(:bishop, color: "White", x_pos: 5, y_pos: 3, game_id: game.id) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Block has too many lines. [111/25]

Open

    context 'When both players have joined' do
      let!(:white_pawn) { FactoryGirl.create(:pawn, color: "White", x_pos: 4, y_pos: 1, game_id: game.id) }
      let!(:black_pawn) { FactoryGirl.create(:pawn, color: "Black", x_pos: 4, y_pos: 6, game_id: game.id) }
      before(:each) { game.update_attributes(turn: 0) }
      before(:each) { sign_out white_player }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Block has too many lines. [31/25]

Open

    context 'When there is a check condition' do
      before(:each) { game.pieces.destroy_all } 
      let!(:white_bishop) { FactoryGirl.create(:bishop, color: "White", x_pos: 4, y_pos: 4, game_id: game.id) }
      let!(:black_bishop) { FactoryGirl.create(:bishop, color: "Black", x_pos: 6, y_pos: 4, game_id: game.id) }
      let!(:black_king) { FactoryGirl.create(:king, color: "Black", x_pos: 7, y_pos: 7, game_id: game.id) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Trailing whitespace detected.

Open

          expect(game.turn).to eq(16)              

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [98/80]

Open

    let(:rook) { FactoryGirl.create(:rook, color: "Black", x_pos: 7, y_pos: 7, game_id: game.id) }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [107/80]

Open

      let!(:black_king) { FactoryGirl.create(:king, color: "Black", x_pos: 7, y_pos: 7, game_id: game.id) }

• Exclude checks
  • Disable engine
  • Disable check

Prefer single-quoted strings when you don't need string interpolation or special symbols.

Open

      let!(:white_bishop) { FactoryGirl.create(:bishop, color: "White", x_pos: 4, y_pos: 4, game_id: game.id) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [87/80]

Open

      it 'should not allow White piece/player to move on Black piece/player\'s turn' do

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [92/80]

Open

          patch :update, params: { game_id: game.id, id: black_pawn.id, x_pos: 4, y_pos: 5 }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [81/80]

Open

          expect(flash[:alert]).to match("Sorry, you are not part of this game.")

• Exclude checks
  • Disable engine
  • Disable check

Prefer single-quoted strings when you don't need string interpolation or special symbols.

Open

      let(:player1_pawn) { FactoryGirl.create(:pawn, color: "White", x_pos: 5, y_pos: 1, game_id: game_not_full.id) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [111/80]

Open

      let!(:white_bishop) { FactoryGirl.create(:bishop, color: "White", x_pos: 5, y_pos: 3, game_id: game.id) }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [107/80]

Open

      let!(:black_pawn) { FactoryGirl.create(:pawn, color: "Black", x_pos: 4, y_pos: 6, game_id: game.id) }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [90/80]

Open

        patch :update, params: { game_id: game.id, id: black_pawn.id, x_pos: 4, y_pos: 4 }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [81/80]

Open

          expect(flash[:alert]).to match("Sorry, you are not part of this game.")

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [111/80]

Open

      let!(:white_bishop) { FactoryGirl.create(:bishop, color: "White", x_pos: 4, y_pos: 4, game_id: game.id) }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [107/80]

Open

      let!(:white_king) { FactoryGirl.create(:king, color: "White", x_pos: 4, y_pos: 0, game_id: game.id) }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [107/80]

Open

      let!(:white_pawn) { FactoryGirl.create(:pawn, color: "White", x_pos: 4, y_pos: 1, game_id: game.id) }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [90/80]

Open

        patch :update, params: { game_id: game.id, id: black_pawn.id, x_pos: 4, y_pos: 5 }

• Exclude checks
  • Disable engine
  • Disable check

Prefer single-quoted strings when you don't need string interpolation or special symbols.

Open

      let!(:black_king) { FactoryGirl.create(:king, color: "Black", x_pos: 7, y_pos: 7, game_id: game.id) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [99/80]

Open

        patch :update, params: {game_id: game_not_full.id, id: player1_pawn.id, x_pos: 5, y_pos: 2}

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [90/80]

Open

        patch :update, params: { game_id: game.id, id: white_pawn.id, x_pos: 4, y_pos: 2 }

• Exclude checks
  • Disable engine
  • Disable check

Prefer single-quoted strings when you don't need string interpolation or special symbols.

Open

      let!(:white_bishop) { FactoryGirl.create(:bishop, color: "White", x_pos: 5, y_pos: 3, game_id: game.id) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Trailing whitespace detected.

Open

        expect(black_bishop.y_pos).to eq 4     

• Exclude checks
  • Disable engine
  • Disable check

Trailing whitespace detected.

Open

          expect(game.turn).to eq(23)          

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [90/80]

Open

        patch :update, params: { game_id: game.id, id: black_pawn.id, x_pos: 4, y_pos: 4 }

• Exclude checks
  • Disable engine
  • Disable check

Prefer single-quoted strings when you don't need string interpolation or special symbols.

Open

      let!(:black_king) { FactoryGirl.create(:king, color: "Black", x_pos: 7, y_pos: 7, game_id: game.id) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.

Open

          expect(flash[:alert]).to match("Sorry, you are not part of this game.")

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [117/80]

Open

      let(:player1_pawn) { FactoryGirl.create(:pawn, color: "White", x_pos: 5, y_pos: 1, game_id: game_not_full.id) }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [90/80]

Open

        patch :update, params: { game_id: game.id, id: black_pawn.id, x_pos: 4, y_pos: 5 }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [92/80]

Open

          patch :update, params: { game_id: game.id, id: white_pawn.id, x_pos: 4, y_pos: 2 }

• Exclude checks
  • Disable engine
  • Disable check

Prefer single-quoted strings when you don't need string interpolation or special symbols.

Open

      let!(:white_king) { FactoryGirl.create(:king, color: "White", x_pos: 2, y_pos: 0, game_id: game.id) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.

Open

      let!(:white_king) { FactoryGirl.create(:king, color: "White", x_pos: 4, y_pos: 0, game_id: game.id) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.

Open

        expect(flash[:alert]).to match("Sorry, that move would leave your King in check.")

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Space inside { missing.

Open

        patch :update, params: {game_id: game_not_full.id, id: player1_pawn.id, x_pos: 5, y_pos: 2}

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# The `space` style enforces that hash literals have
# surrounding space.

# bad
h = {a: 1, b: 2}

# good
h = { a: 1, b: 2 }

# The `no_space` style enforces that hash literals have
# no surrounding space.

# bad
h = { a: 1, b: 2 }

# good
h = {a: 1, b: 2}

# The `compact` style normally requires a space inside
# hash braces, with the exception that successive left
# braces or right braces are collapsed together in nested hashes.

# bad
h = { a: { b: 2 } }

# good
h = { a: { b: 2 }}

Line is too long. [87/80]

Open

      it 'should not allow Black piece/player to move on White piece/player\'s turn' do

• Exclude checks
  • Disable engine
  • Disable check

Trailing whitespace detected.

Open

    end   

• Exclude checks
  • Disable engine
  • Disable check

Prefer single-quoted strings when you don't need string interpolation or special symbols.

Open

      let!(:white_pawn) { FactoryGirl.create(:pawn, color: "White", x_pos: 4, y_pos: 1, game_id: game.id) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.

Open

          expect(flash[:alert]).to match("Sorry, you are not part of this game.")

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Trailing whitespace detected.

Open

      before(:each) { game.pieces.destroy_all } 

• Exclude checks
  • Disable engine
  • Disable check

Trailing whitespace detected.

Open

          game.reload          

• Exclude checks
  • Disable engine
  • Disable check

Trailing whitespace detected.

Open

  end 

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [110/80]

Open

  let(:game) { FactoryGirl.create(:game, white_player_id: white_player.id, black_player_id: black_player.id) }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [107/80]

Open

      let!(:black_king) { FactoryGirl.create(:king, color: "Black", x_pos: 7, y_pos: 7, game_id: game.id) }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [90/80]

Open

        expect(flash[:alert]).to match("Sorry, that move would leave your King in check.")

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [90/80]

Open

        patch :update, params: { game_id: game.id, id: white_pawn.id, x_pos: 4, y_pos: 3 }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [92/80]

Open

        patch :update, params: { game_id: game.id, id: black_bishop.id, x_pos: 7, y_pos: 3 }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [81/80]

Open

        # expect(flash[:alert]).to match("Waiting for another player to join...")

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [90/80]

Open

        patch :update, params: { game_id: game.id, id: white_pawn.id, x_pos: 4, y_pos: 2 }

• Exclude checks
  • Disable engine
  • Disable check

Prefer single-quoted strings when you don't need string interpolation or special symbols.

Open

      let!(:black_pawn) { FactoryGirl.create(:pawn, color: "Black", x_pos: 4, y_pos: 6, game_id: game.id) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [107/80]

Open

      let!(:white_king) { FactoryGirl.create(:king, color: "White", x_pos: 2, y_pos: 0, game_id: game.id) }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [92/80]

Open

        patch :update, params: { game_id: game.id, id: black_bishop.id, x_pos: 5, y_pos: 5 }

• Exclude checks
  • Disable engine
  • Disable check

Prefer single-quoted strings when you don't need string interpolation or special symbols.

Open

    let(:rook) { FactoryGirl.create(:rook, color: "Black", x_pos: 7, y_pos: 7, game_id: game.id) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.

Open

        expect(game.check?("Black")).to eq(true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Space inside } missing.

Open

        patch :update, params: {game_id: game_not_full.id, id: player1_pawn.id, x_pos: 5, y_pos: 2}

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# The `space` style enforces that hash literals have
# surrounding space.

# bad
h = {a: 1, b: 2}

# good
h = { a: 1, b: 2 }

# The `no_space` style enforces that hash literals have
# no surrounding space.

# bad
h = { a: 1, b: 2 }

# good
h = {a: 1, b: 2}

# The `compact` style normally requires a space inside
# hash braces, with the exception that successive left
# braces or right braces are collapsed together in nested hashes.

# bad
h = { a: { b: 2 } }

# good
h = { a: { b: 2 }}

Trailing whitespace detected.

Open

      before(:each) { game.pieces.destroy_all } 

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [92/80]

Open

        patch :update, params: { game_id: game.id, id: white_bishop.id, x_pos: 4, y_pos: 4 }

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [111/80]

Open

      let(:game_not_full) { FactoryGirl.create(:game, white_player_id: white_player.id, black_player_id: nil) }

• Exclude checks
  • Disable engine
  • Disable check

Prefer single-quoted strings when you don't need string interpolation or special symbols.

Open

      let!(:black_bishop) { FactoryGirl.create(:bishop, color: "Black", x_pos: 6, y_pos: 4, game_id: game.id) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Extra empty line detected at block body end.

Open

    end

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# good

foo do |bar|

  # ...

end

# good

foo do |bar|
  # ...
end

Trailing whitespace detected.

Open

• Exclude checks
  • Disable engine
  • Disable check

Trailing whitespace detected.

Open

        expect(game.turn).to eq(19)        

• Exclude checks
  • Disable engine
  • Disable check

Line is too long. [111/80]

Open

      let!(:black_bishop) { FactoryGirl.create(:bishop, color: "Black", x_pos: 6, y_pos: 4, game_id: game.id) }

• Exclude checks
  • Disable engine
  • Disable check