Sign upLogin

TheSharpieOne/angular-validation-match

View on GitHub
Star
test/angular-input-match.spec.js

Summary

Maintainability
F
1 wk
Test Coverage

File angular-input-match.spec.js has 336 lines of code (exceeds 250 allowed). Consider refactoring.
Open

describe('Directives: validation - match', function() {

    var $scope,
    $compile,
    compiled;
Severity: Minor
Found in test/angular-input-match.spec.js - About 4 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        describe('not-match validation', function() {

      describe('behavior:', function() {
        var validTemplate = '<input ng-model="confirmation" match="original" not-match="true"></input>';
    Severity: Major
    Found in test/angular-input-match.spec.js and 2 other locations - About 4 days to fix
    test/angular-input-match.spec.js on lines 113..191
    test/angular-input-match.spec.js on lines 273..351

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 732.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        describe('caseless validation', function() {

      describe('behavior:', function() {
        var validTemplate = '<input ng-model="confirmation" match="original" match-caseless="true"></input>';
    Severity: Major
    Found in test/angular-input-match.spec.js and 2 other locations - About 4 days to fix
    test/angular-input-match.spec.js on lines 193..271
    test/angular-input-match.spec.js on lines 273..351

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 732.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        describe('not-match with caseless validation', function() {

      describe('behavior:', function() {
        var validTemplate = '<input ng-model="confirmation" match="original" match-caseless="true" not-match="true"></input>';
    Severity: Major
    Found in test/angular-input-match.spec.js and 2 other locations - About 4 days to fix
    test/angular-input-match.spec.js on lines 113..191
    test/angular-input-match.spec.js on lines 193..271

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 732.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status