Showing 10 of 10 total issues
File k8s-api.js
has 518 lines of code (exceeds 250 allowed). Consider refactoring. Open
import k8s from '@kubernetes/client-node';
import {k8sManifest} from '@thinkdeep/k8s-manifest';
import {ErrorNotFound} from './error/error-not-found.js';
import {normalizeKind} from './normalize-kind.js';
K8sApi
has 37 functions (exceeds 20 allowed). Consider refactoring. Open
class K8sApi {
/**
* Constructor for theeee K8sApi object.
*/
constructor() {
Function _patchClusterObjectStrategy
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
_patchClusterObjectStrategy(api, kind, manifest) {
const pretty = undefined;
const dryRun = undefined;
Function _forEachApi
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
async _forEachApi(kubeConfig, resourceFunctionName, callback, apis) {
if (!(kubeConfig instanceof k8s.KubeConfig)) {
throw new Error(`Supplied k8s kube configuration was invalid.`);
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function listAll
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
async listAll(kind, namespace) {
if (!this._registeredKind(kind)) {
throw new ErrorNotFound(
`Kind ${kind} was not found in the API. Are you sure it's correctly spelled?`
);
Function _forEachApi
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
async _forEachApi(kubeConfig, resourceFunctionName, callback, apis) {
if (!(kubeConfig instanceof k8s.KubeConfig)) {
throw new Error(`Supplied k8s kube configuration was invalid.`);
}
Similar blocks of code found in 2 locations. Consider refactoring. Open
async applyAll(configurations) {
const targets = [];
for (const configuration of configurations) {
targets.push(await this.apply(configuration));
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 58.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
async createAll(configurations) {
const targets = [];
for (const configuration of configurations) {
targets.push(await this.create(configuration));
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 58.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function createAll
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
async createAll(manifests) {
const targets = [];
for (const manifest of manifests) {
try {
const strategy = this._creationStrategy(manifest);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _listClusterObjectsStrategy
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
_listClusterObjectsStrategy(api, kind, namespace) {
const _kind = normalizeKind(kind);
if (!this._registeredKind(_kind)) {
throw new ErrorNotFound(
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"