Sign upLogin

ThomasR/nonogram-solver

View on GitHub
Star

Showing 38 of 38 total issues

Function guessAndConquer has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

let guessAndConquer = (strategy, puzzle, currentRecursionLevel = 0) => {
  const maxGuessCount = 100;
  if (puzzle.isFinished) {
    return puzzle.isSolved ? puzzle : null;
  }
Severity: Major
Found in src/guessAndConquer.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            let line = [-1, -1, -1, -1, -1, -1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, -1, -1, 1, 1, -1, 0, 0, 0, 0, 0, 0, -1, -1, -1, -1, 1, -1];
    Severity: Major
    Found in test/pushSolver.test.js and 1 other location - About 2 hrs to fix
    test/util.test.js on lines 51..51

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          let fixture = [-1, -1, -1, -1, -1, -1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, -1, -1, 1, 1, -1, 0, 0, 0, 0, 0, 0, -1, -1, -1, -1, 1, -1];
    Severity: Major
    Found in test/util.test.js and 1 other location - About 2 hrs to fix
    test/pushSolver.test.js on lines 282..282

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function run has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        let run = (lines, hints, onRow) => {
      let visited = onRow ?
        {current: this.visited.rows, other: this.visited.columns} :
        {current: this.visited.columns, other: this.visited.rows};
      let rearrangedLines = optimizeOrder(lines, hints);
    Severity: Major
    Found in src/Strategy.js - About 2 hrs to fix

      Function solve has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        solve(puzzle, withTrialAndError = true) {
    if (debugMode) {
      var start = Date.now();
      var statistics = Array(this.solvers.length).fill(0);
      var solutionSequence = [];
      Severity: Minor
      Found in src/Strategy.js - About 1 hr to fix

        Function exports has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = (id, callback) => {

  console.log(`Downloading puzzle ${id}`);
  const getCB = (error, {statusCode}, body) => {
    if (error || statusCode !== 200) {
        Severity: Minor
        Found in puzzles/nonograms.org/downloader.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                fs.readFile(path.resolve(__dirname, 'output', 'invalidPuzzle.svg'), err => {
        if (err.code === 'ENOENT') {
          done();
        } else {
          done(new Error('Unexpected output file'));
          Severity: Major
          Found in test/cli.test.js and 1 other location - About 1 hr to fix
          test/cli.test.js on lines 82..88

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 64.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                fs.readFile(path.resolve(__dirname, 'output', 'unsolvablePuzzle.svg'), err => {
        if (err.code === 'ENOENT') {
          done();
        } else {
          done(new Error('Unexpected output file'));
          Severity: Major
          Found in test/cli.test.js and 1 other location - About 1 hr to fix
          test/cli.test.js on lines 62..68

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 64.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function solveOnce has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            solveOnce(puzzle, solver, solverIndex, solutionSequence) {
    // If we're dealing with a slow solver, we want to skip as soon as one line is partially solved
    let skipEarly = solver.speed === 'slow';
    let skip = false;
          Severity: Minor
          Found in src/Strategy.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function run has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          let run = inputFile => {
  console.error(`Processing ${inputFile}`);
  let input = path.resolve(process.cwd(), inputFile);
  let baseFileName = path.basename(inputFile).replace(/\.json$/, '');
          Severity: Minor
          Found in src/cli.js - About 1 hr to fix

            Function jsonRunner has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const jsonRunner = (solve, filename) => {

  const runTests = o => {
    if (o.describe) {
      describe(o.describe[0], () => {
            Severity: Minor
            Found in test/runTestsOnJSON.js - About 1 hr to fix

              Function gapDistributor has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              let gapDistributor = (line, hints) => {
  let gaps = findGaps(line);
  if (gaps.length === 1) {
    return allWithOneGap(line, gaps, hints);
  }
              Severity: Minor
              Found in src/gapDistributor.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      rows: {
        get() {
          return rows;
        },
        set(newRows) {
                Severity: Major
                Found in src/Puzzle.js and 1 other location - About 1 hr to fix
                src/Puzzle.js on lines 103..112

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 55.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      columns: {
        get() {
          return columns;
        },
        set(cols) {
                Severity: Major
                Found in src/Puzzle.js and 1 other location - About 1 hr to fix
                src/Puzzle.js on lines 93..102

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 55.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function solve has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                  solve(puzzle, withTrialAndError = true) {
    if (debugMode) {
      var start = Date.now();
      var statistics = Array(this.solvers.length).fill(0);
      var solutionSequence = [];
                Severity: Minor
                Found in src/Strategy.js - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Consider simplifying this complex logical expression.
                Open

                    if (content) {
      let invalid = !content || !Array.isArray(content);
      invalid = invalid || (content.length !== this.height * this.width);
      invalid = invalid || !content.every(i => i === -1 || i === 0 || i === 1);
      assert(!invalid, 'Invalid content data');
                Severity: Major
                Found in src/Puzzle.js - About 40 mins to fix

                  Function gapDistributor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                  let gapDistributor = (line, hints) => {
  let gaps = findGaps(line);
  if (gaps.length === 1) {
    return allWithOneGap(line, gaps, hints);
  }
                  Severity: Minor
                  Found in src/gapDistributor.js - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function findGaps has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  let findGaps = line => line.reduce((result, el, i, line) => {
  if (el > -1) {
    if (line[i - 1] > -1) {
      result[result.length - 1][1]++;
    } else {
                  Severity: Minor
                  Found in src/gapDistributor.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language