Sign upLogin

Thruio/ActiveRecord

View on GitHub
Star

Showing 50 of 50 total issues

Method __getListOfReservedWords has 228 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function __getListOfReservedWords()
    {
        return array(
          "ACCESSIBLE",
          "ADD",
Severity: Major
Found in src/DatabaseLayer/Table.php - About 1 day to fix

    File ActiveRecord.php has 420 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace Thru\ActiveRecord;

use Guzzle\Common\Version;
    Severity: Minor
    Found in src/ActiveRecord.php - About 6 hrs to fix

      ActiveRecord has 40 functions (exceeds 20 allowed). Consider refactoring.
      Open

      abstract class ActiveRecord
{
    static public $MYSQL_FORMAT = "Y-m-d H:i:s";
    static public $showSql;
    protected $_label_column = null;
      Severity: Minor
      Found in src/ActiveRecord.php - About 5 hrs to fix

        Function buildTable has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
        Open

            public function buildTable(ActiveRecord $model)
    {
        $schema = $model->getClassSchema();
        $params = array();
        foreach ($model->__calculateSaveDownRows() as $p => $parameter) {
        Severity: Minor
        Found in src/DatabaseLayer/Sql/Mysql.php - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function buildTable has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
        Open

            public function buildTable(ActiveRecord $model)
    {
        $schema = $model->getClassSchema();
        $params = array();
        foreach ($model->__calculateSaveDownRows() as $p => $parameter) {
        Severity: Minor
        Found in src/DatabaseLayer/Sql/Postgres.php - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method buildTable has 80 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function buildTable(ActiveRecord $model)
    {
        $schema = $model->getClassSchema();
        $params = array();
        foreach ($model->__calculateSaveDownRows() as $p => $parameter) {
        Severity: Major
        Found in src/DatabaseLayer/Sql/Mysql.php - About 3 hrs to fix

          Function processSelect has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
          Open

              public function processSelect(DatabaseLayer\Select $thing)
    {
        $fields = array();
        $tables = array();
        $orders = array();
          Severity: Minor
          Found in src/DatabaseLayer/Sql/Sqlite.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method buildTable has 77 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function buildTable(ActiveRecord $model)
    {
        $schema = $model->getClassSchema();
        $params = array();
        foreach ($model->__calculateSaveDownRows() as $p => $parameter) {
          Severity: Major
          Found in src/DatabaseLayer/Sql/Postgres.php - About 3 hrs to fix

            File Table.php has 289 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
namespace Thru\ActiveRecord\DatabaseLayer;

class Table
{
            Severity: Minor
            Found in src/DatabaseLayer/Table.php - About 2 hrs to fix

              Function buildTable has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function buildTable(ActiveRecord $model)
    {
        $schema = $model->getClassSchema();
        $params = array();
        foreach ($model->__calculateSaveDownRows() as $p => $parameter) {
              Severity: Minor
              Found in src/DatabaseLayer/Sql/Sqlite.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File Postgres.php has 283 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
namespace Thru\ActiveRecord\DatabaseLayer\Sql;

use Monolog\Logger;
use Thru\ActiveRecord\DatabaseLayer;
              Severity: Minor
              Found in src/DatabaseLayer/Sql/Postgres.php - About 2 hrs to fix

                Function processSelect has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function processSelect(DatabaseLayer\Select $thing)
    {
        $fields = array();
        $tables = array();
        $orders = array();
                Severity: Minor
                Found in src/DatabaseLayer/Sql/Postgres.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method processSelect has 67 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function processSelect(DatabaseLayer\Select $thing)
    {
        $fields = array();
        $tables = array();
        $orders = array();
                Severity: Major
                Found in src/DatabaseLayer/Sql/Sqlite.php - About 2 hrs to fix

                  Function processSelect has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function processSelect(DatabaseLayer\Select $thing)
    {
        $fields = array();
        $tables = array();
        $orders = array();
                  Severity: Minor
                  Found in src/DatabaseLayer/Sql/Mysql.php - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method processSelect has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function processSelect(DatabaseLayer\Select $thing)
    {
        $fields = array();
        $tables = array();
        $orders = array();
                  Severity: Major
                  Found in src/DatabaseLayer/Sql/Postgres.php - About 2 hrs to fix

                    Method processSelect has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function processSelect(DatabaseLayer\Select $thing)
    {
        $fields = array();
        $tables = array();
        $orders = array();
                    Severity: Major
                    Found in src/DatabaseLayer/Sql/Mysql.php - About 2 hrs to fix

                      File Sqlite.php has 260 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php
namespace Thru\ActiveRecord\DatabaseLayer\Sql;

use Monolog\Logger;
use Thru\ActiveRecord\ActiveRecord;
                      Severity: Minor
                      Found in src/DatabaseLayer/Sql/Sqlite.php - About 2 hrs to fix

                        Method buildTable has 56 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function buildTable(ActiveRecord $model)
    {
        $schema = $model->getClassSchema();
        $params = array();
        foreach ($model->__calculateSaveDownRows() as $p => $parameter) {
                        Severity: Major
                        Found in src/DatabaseLayer/Sql/Sqlite.php - About 2 hrs to fix

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  foreach ($thing->getData() as $key => $value) {
            $key = trim($key, "`");
            if (is_object($value) || is_array($value)) {
                $value = JsonPrettyPrinter::Json($value);
            }
                          Severity: Major
                          Found in src/DatabaseLayer/Sql/Mysql.php and 1 other location - About 2 hrs to fix
                          src/DatabaseLayer/Sql/Mysql.php on lines 146..157

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 122.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  foreach ($thing->getData() as $key => $value) {
            $key = trim($key, "`");
            if (is_object($value) || is_array($value)) {
                $value = JsonPrettyPrinter::Json($value);
            }
                          Severity: Major
                          Found in src/DatabaseLayer/Sql/Mysql.php and 1 other location - About 2 hrs to fix
                          src/DatabaseLayer/Sql/Mysql.php on lines 112..123

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 122.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language