TiagoMSSantos/MobileRT

View on GitHub
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java

Summary

Maintainability
A
2 hrs
Test Coverage

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @Test
    public void testRenderSceneWithWhitted() throws TimeoutException {
        mockFileManagerReply(false,
            ConstantsAndroidTests.CORNELL_BOX_WATER_OBJ,
            ConstantsAndroidTests.CORNELL_BOX_WATER_MTL,
app/src/androidTest/java/puscas/mobilertapp/RayTracingTest.java on lines 78..87
app/src/androidTest/java/puscas/mobilertapp/engine/AcceleratorTest.java on lines 35..44
app/src/androidTest/java/puscas/mobilertapp/engine/AcceleratorTest.java on lines 51..60
app/src/androidTest/java/puscas/mobilertapp/engine/AcceleratorTest.java on lines 67..76
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 24..33
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 56..65
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 72..81
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 88..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @Test
    public void testRenderSceneWithDepthMap() throws TimeoutException {
        mockFileManagerReply(false,
            ConstantsAndroidTests.CORNELL_BOX_WATER_OBJ,
            ConstantsAndroidTests.CORNELL_BOX_WATER_MTL,
app/src/androidTest/java/puscas/mobilertapp/RayTracingTest.java on lines 78..87
app/src/androidTest/java/puscas/mobilertapp/engine/AcceleratorTest.java on lines 35..44
app/src/androidTest/java/puscas/mobilertapp/engine/AcceleratorTest.java on lines 51..60
app/src/androidTest/java/puscas/mobilertapp/engine/AcceleratorTest.java on lines 67..76
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 24..33
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 40..49
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 56..65
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 88..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @Test
    public void testRenderSceneWithNoShadows() throws TimeoutException {
        mockFileManagerReply(false,
            ConstantsAndroidTests.CORNELL_BOX_WATER_OBJ,
            ConstantsAndroidTests.CORNELL_BOX_WATER_MTL,
app/src/androidTest/java/puscas/mobilertapp/RayTracingTest.java on lines 78..87
app/src/androidTest/java/puscas/mobilertapp/engine/AcceleratorTest.java on lines 35..44
app/src/androidTest/java/puscas/mobilertapp/engine/AcceleratorTest.java on lines 51..60
app/src/androidTest/java/puscas/mobilertapp/engine/AcceleratorTest.java on lines 67..76
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 40..49
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 56..65
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 72..81
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 88..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @Test
    public void testRenderSceneWithPathTracing() throws TimeoutException {
        mockFileManagerReply(false,
            ConstantsAndroidTests.CORNELL_BOX_WATER_OBJ,
            ConstantsAndroidTests.CORNELL_BOX_WATER_MTL,
app/src/androidTest/java/puscas/mobilertapp/RayTracingTest.java on lines 78..87
app/src/androidTest/java/puscas/mobilertapp/engine/AcceleratorTest.java on lines 35..44
app/src/androidTest/java/puscas/mobilertapp/engine/AcceleratorTest.java on lines 51..60
app/src/androidTest/java/puscas/mobilertapp/engine/AcceleratorTest.java on lines 67..76
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 24..33
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 40..49
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 72..81
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 88..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @Test
    public void testRenderSceneWithDiffuse() throws TimeoutException {
        mockFileManagerReply(false,
            ConstantsAndroidTests.CORNELL_BOX_WATER_OBJ,
            ConstantsAndroidTests.CORNELL_BOX_WATER_MTL,
app/src/androidTest/java/puscas/mobilertapp/RayTracingTest.java on lines 78..87
app/src/androidTest/java/puscas/mobilertapp/engine/AcceleratorTest.java on lines 35..44
app/src/androidTest/java/puscas/mobilertapp/engine/AcceleratorTest.java on lines 51..60
app/src/androidTest/java/puscas/mobilertapp/engine/AcceleratorTest.java on lines 67..76
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 24..33
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 40..49
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 56..65
app/src/androidTest/java/puscas/mobilertapp/engine/ShaderTest.java on lines 72..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Wrong lexicographical order for 'java.util.concurrent.TimeoutException' import. Should be before 'org.junit.Test'.
Open

import java.util.concurrent.TimeoutException;

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'java.util.concurrent.TimeoutException'
Open

import java.util.concurrent.TimeoutException;

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'puscas.mobilertapp.AbstractTest'
Open

import puscas.mobilertapp.AbstractTest;

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

There are no issues that match your filters.

Category
Status