Sign upLogin

TiagoMSSantos/MobileRT

View on GitHub
Star
app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java

Summary

Maintainability
A
0 mins
Test Coverage

Don't try to be smarter than the JVM, remove this call to run the garbage collector.
Open

        Runtime.getRuntime().gc();
Severity: Critical
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by sonar-java

Calling System.gc() or Runtime.getRuntime().gc() is a bad idea for a simple reason: there is no way to know exactly what will be done under the hood by the JVM because the behavior will depend on its vendor, version and options:

  • Will the whole application be frozen during the call?
  • Is the -XX:DisableExplicitGC option activated?
  • Will the JVM simply ignore the call?
  • ...

Like for System.gc(), there is no reason to manually call runFinalization() to force the call of finalization methods of any objects pending finalization.

An application relying on these unpredictable methods is also unpredictable and therefore broken. The task of running the garbage collector and calling finalize() methods should be left exclusively to the JVM.

Don't try to be smarter than the JVM, remove this call to run the garbage collector.
Open

            Runtime.getRuntime().gc();
Severity: Critical
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by sonar-java

Calling System.gc() or Runtime.getRuntime().gc() is a bad idea for a simple reason: there is no way to know exactly what will be done under the hood by the JVM because the behavior will depend on its vendor, version and options:

  • Will the whole application be frozen during the call?
  • Is the -XX:DisableExplicitGC option activated?
  • Will the JVM simply ignore the call?
  • ...

Like for System.gc(), there is no reason to manually call runFinalization() to force the call of finalization methods of any objects pending finalization.

An application relying on these unpredictable methods is also unpredictable and therefore broken. The task of running the garbage collector and calling finalize() methods should be left exclusively to the JVM.

Extra separation in import group before 'java.nio.ByteBuffer'
Open

import java.nio.ByteBuffer;
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'java.util.Collection' import. Should be before 'puscas.mobilertapp.ConstantsAndroidTests.NOT_ENOUGH_MEMORY_MESSAGE'.
Open

import java.util.Collection;
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'puscas.mobilertapp.AbstractTest'
Open

import puscas.mobilertapp.AbstractTest;
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 238).
Open

        for(long memAllocated = 0L; getAvailableNativeMemoryInMB() > 0L && firstAvailableMemoryMB > getAvailableNativeMemoryInMB() + 2L * megaBytesToAllocate && memAllocated < maxMegaBytesToAllocate; memAllocated += megaBytesToAllocate) {
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'puscas.mobilertapp.ConstantsAndroidTests.NOT_ENOUGH_MEMORY_MESSAGE'.
Open

import java.util.ArrayList;
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 108).
Open

            dummyArrays.add(ByteBuffer.allocateDirect((megaBytesToAllocate * Constants.BYTES_IN_MEGABYTE)));
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'android.os.Debug'
Open

import android.os.Debug;
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'org.junit.Test' import. Should be before 'puscas.mobilertapp.ConstantsAndroidTests.NOT_ENOUGH_MEMORY_MESSAGE'.
Open

import org.junit.Test;
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 109).
Open

     * Tests that allocating heap memory from native memory, makes the available memory decrease as expected.
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 168).
Open

            Assert.assertTrue(NOT_ENOUGH_MEMORY_MESSAGE + firstAvailableMemoryMB + " >= " + expectedAvailableMemory, firstAvailableMemoryMB >= expectedAvailableMemory);
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'android.os.Debug' import. Should be before 'puscas.mobilertapp.ConstantsAndroidTests.NOT_ENOUGH_MEMORY_MESSAGE'.
Open

import android.os.Debug;
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

<p> tag should be placed immediately before the first word, with no space after.</p>
Open

 * <p>
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks the Javadoc paragraph.

Checks that:

  • There is one blank line between each of two paragraphs.
  • Each paragraph but the first has <p> immediately before the first word, withno space after.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'org.junit.Assert'
Open

import org.junit.Assert;
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 164).
Open

            Assert.assertTrue(NOT_ENOUGH_MEMORY_MESSAGE + afterAvailableMemory + " <= " + beforeAvailableMemoryMB, afterAvailableMemory <= beforeAvailableMemoryMB);
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 135).
Open

        Assert.assertEquals( "The number of allocated `ByteBuffer` is not the expected.", numAllocatedByteBuffers, dummyArrays.size());
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'org.junit.Assert' import. Should be before 'puscas.mobilertapp.ConstantsAndroidTests.NOT_ENOUGH_MEMORY_MESSAGE'.
Open

import org.junit.Assert;
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'java.util.Locale' import. Should be before 'puscas.mobilertapp.ConstantsAndroidTests.NOT_ENOUGH_MEMORY_MESSAGE'.
Open

import java.util.Locale;
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

<p> tag should be preceded with an empty line.</p>
Open

 * <p>
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks the Javadoc paragraph.

Checks that:

  • There is one blank line between each of two paragraphs.
  • Each paragraph but the first has <p> immediately before the first word, withno space after.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'java.nio.ByteBuffer' import. Should be before 'puscas.mobilertapp.ConstantsAndroidTests.NOT_ENOUGH_MEMORY_MESSAGE'.
Open

import java.nio.ByteBuffer;
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'java.util.logging.Logger' import. Should be before 'puscas.mobilertapp.ConstantsAndroidTests.NOT_ENOUGH_MEMORY_MESSAGE'.
Open

import java.util.logging.Logger;
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'puscas.mobilertapp.AbstractTest' import. Should be before 'puscas.mobilertapp.ConstantsAndroidTests.NOT_ENOUGH_MEMORY_MESSAGE'.
Open

import puscas.mobilertapp.AbstractTest;
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

There are no issues that match your filters.

Category
Status