Sign upLogin

TiagoMSSantos/MobileRT

View on GitHub
Star
app/src/main/java/puscas/mobilertapp/DrawView.java

Summary

Maintainability
A
3 hrs
Test Coverage

File DrawView.java has 252 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package puscas.mobilertapp;

import android.app.Activity;
import android.app.ActivityManager;
import android.content.Context;
Severity: Minor
Found in app/src/main/java/puscas/mobilertapp/DrawView.java - About 2 hrs to fix

    Method renderScene has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        synchronized void renderScene(@NonNull final Config config) {
        logger.info(ConstantsMethods.RENDER_SCENE);

        MainActivity.resetErrno();
        stopDrawing();
    Severity: Minor
    Found in app/src/main/java/puscas/mobilertapp/DrawView.java - About 1 hr to fix

      Define a constant instead of duplicating this literal "onPause" 3 times.
      Open

              logger.info("onPause");
      Severity: Critical
      Found in app/src/main/java/puscas/mobilertapp/DrawView.java by sonar-java

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

      Compliant Solution

      private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "DrawView#waitLastTask" 3 times.
      Open

                          UtilsLogging.logThrowable(ex, "DrawView#waitLastTask");
      Severity: Critical
      Found in app/src/main/java/puscas/mobilertapp/DrawView.java by sonar-java

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

      Compliant Solution

      private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Extra separation in import group before 'java8.util.Optional'
      Open

      import java8.util.Optional;
      Severity: Minor
      Found in app/src/main/java/puscas/mobilertapp/DrawView.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 164).
      Open

              final long tasksAlreadyDone = this.executorService instanceof ThreadPoolExecutor? ((ThreadPoolExecutor) this.executorService).getCompletedTaskCount() : -1L;
      Severity: Minor
      Found in app/src/main/java/puscas/mobilertapp/DrawView.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 138).
      Open

              while (this.lastTask != null && ((ThreadPoolExecutor) this.executorService).getCompletedTaskCount() <= this.lastTask.getFirst()) {
      Severity: Minor
      Found in app/src/main/java/puscas/mobilertapp/DrawView.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 115).
      Open

          private final ExecutorService executorService = Executors.newFixedThreadPool(ConstantsRenderer.NUMBER_THREADS);
      Severity: Minor
      Found in app/src/main/java/puscas/mobilertapp/DrawView.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Extra separation in import group before 'java.util.Map'
      Open

      import java.util.Map;
      Severity: Minor
      Found in app/src/main/java/puscas/mobilertapp/DrawView.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Extra separation in import group before 'com.google.common.util.concurrent.Uninterruptibles'
      Open

      import com.google.common.util.concurrent.Uninterruptibles;
      Severity: Minor
      Found in app/src/main/java/puscas/mobilertapp/DrawView.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 106).
      Open

                      MainActivity.showUiMessage(ConstantsToast.DEVICE_WITHOUT_ENOUGH_MEMORY + ex.getMessage());
      Severity: Minor
      Found in app/src/main/java/puscas/mobilertapp/DrawView.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Extra separation in import group before 'androidx.annotation.NonNull'
      Open

      import androidx.annotation.NonNull;
      Severity: Minor
      Found in app/src/main/java/puscas/mobilertapp/DrawView.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 102).
      Open

                      MainActivity.showUiMessage(ConstantsToast.COULD_NOT_LOAD_THE_SCENE + ex.getMessage());
      Severity: Minor
      Found in app/src/main/java/puscas/mobilertapp/DrawView.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 115).
      Open

              logger.info("onWindowFocusChanged hasWindowFocus: " + hasWindowFocus + ", visibility: " + getVisibility());
      Severity: Minor
      Found in app/src/main/java/puscas/mobilertapp/DrawView.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      There are no issues that match your filters.

      Category
      Status