Sign upLogin

TiagoMSSantos/MobileRT

View on GitHub
Star

Showing 666 of 666 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                if (this.viewId == R.id.preview) {
                    final CheckBox checkbox = view.findViewById(this.viewId);
                    value = checkbox.isChecked();
                }
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/ViewActionWait.java and 1 other location - About 30 mins to fix
app/src/androidTest/java/puscas/mobilertapp/ViewActionWait.java on lines 93..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                if (this.viewId == R.id.preview) {
                    final CheckBox checkbox = view.findViewById(this.viewId);
                    value = checkbox.isChecked();
                }
Severity: Minor
Found in app/src/androidTest/java/puscas/mobilertapp/ViewActionWait.java and 1 other location - About 30 mins to fix
app/src/androidTest/java/puscas/mobilertapp/ViewActionWait.java on lines 84..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

            return order;
Severity: Major
Found in app/src/androidTest/java/puscas/mobilertapp/OrderRunner.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return orderedTests;
    Severity: Major
    Found in app/src/androidTest/java/puscas/mobilertapp/OrderRunner.java - About 30 mins to fix

      Method onRequestPermissionsResult has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    public void onRequestPermissionsResult(final int requestCode,
                                           @NonNull final String[] permissions,
                                           @NonNull final int[] grantResults) {
        super.onRequestPermissionsResult(requestCode, permissions, grantResults);
      Severity: Minor
      Found in app/src/main/java/puscas/mobilertapp/MainActivity.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Extra separation in import group before 'java.nio.ByteBuffer'
      Open

      import java.nio.ByteBuffer;
      Severity: Minor
      Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Wrong lexicographical order for 'java.util.Collection' import. Should be before 'puscas.mobilertapp.ConstantsAndroidTests.NOT_ENOUGH_MEMORY_MESSAGE'.
      Open

      import java.util.Collection;
      Severity: Minor
      Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Extra separation in import group before 'puscas.mobilertapp.AbstractTest'
      Open

      import puscas.mobilertapp.AbstractTest;
      Severity: Minor
      Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 238).
      Open

              for(long memAllocated = 0L; getAvailableNativeMemoryInMB() > 0L && firstAvailableMemoryMB > getAvailableNativeMemoryInMB() + 2L * megaBytesToAllocate && memAllocated < maxMegaBytesToAllocate; memAllocated += megaBytesToAllocate) {
      Severity: Minor
      Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Wrong lexicographical order for 'java.io.File' import. Should be before 'org.junit.Test'.
      Open

      import java.io.File;
      Severity: Minor
      Found in app/src/androidTest/java/puscas/mobilertapp/system/FileSystemTest.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 126).
      Open

              final String sdCardPath = UtilsContext.getSdCardPath(InstrumentationRegistry.getInstrumentation().getTargetContext());
      Severity: Minor
      Found in app/src/androidTest/java/puscas/mobilertapp/system/FileSystemTest.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 102).
      Open

       * This class doesn't need a {@link Logger} because the method {@link ViewActionWait#getDescription()}
      Severity: Minor
      Found in app/src/androidTest/java/puscas/mobilertapp/ViewActionWait.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'puscas.mobilertapp.ConstantsAndroidTests.NOT_ENOUGH_MEMORY_MESSAGE'.
      Open

      import java.util.ArrayList;
      Severity: Minor
      Found in app/src/androidTest/java/puscas/mobilertapp/system/NativeMemoryTest.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 126).
      Open

              final String sdCardPath = UtilsContext.getSdCardPath(InstrumentationRegistry.getInstrumentation().getTargetContext());
      Severity: Minor
      Found in app/src/androidTest/java/puscas/mobilertapp/system/FileSystemTest.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Wrong lexicographical order for 'java.util.concurrent.TimeoutException' import. Should be before 'org.junit.Test'.
      Open

      import java.util.concurrent.TimeoutException;
      Severity: Minor
      Found in app/src/androidTest/java/puscas/mobilertapp/engine/AcceleratorTest.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Wrong lexicographical order for 'java.util.logging.Logger' import. Should be before 'org.hamcrest.Matcher'.
      Open

      import java.util.logging.Logger;
      Severity: Minor
      Found in app/src/androidTest/java/puscas/mobilertapp/ViewActionWait.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line is longer than 100 characters (found 103).
      Open

           * Let MobileRT continue processing for some time, or to become idle in case {@code 0} milliseconds
      Severity: Minor
      Found in app/src/androidTest/java/puscas/mobilertapp/ViewActionWait.java by checkstyle

      Checks for long lines.

      Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Extra separation in import group before 'java.util.concurrent.TimeoutException'
      Open

      import java.util.concurrent.TimeoutException;
      Severity: Minor
      Found in app/src/androidTest/java/puscas/mobilertapp/RayTracingTest.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Wrong lexicographical order for 'java.util.logging.Logger' import. Should be before 'org.junit.Test'.
      Open

      import java.util.logging.Logger;
      Severity: Minor
      Found in app/src/androidTest/java/puscas/mobilertapp/RayTracingTest.java by checkstyle

      Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Line continuation have incorrect indentation level, expected level should be 4.
      Open

           * file:///file/data/local/tmp/MobileRT/WavefrontOBJs/teapot/teapot.obj<br>
      Severity: Minor
      Found in app/src/androidTest/java/puscas/mobilertapp/RayTracingTest.java by checkstyle

      Checks the indentation of the continuation lines in block tags.That is whether thecontinued description of at clauses should be indented or not. If the text is not properlyindented it throws a violation. A continuation line is when the description starts/spanspast the line with the tag. Default indentation required is at least 4, but this can bechanged with the help of properties below.

      This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

      Severity
      Category
      Status
      Source
      Language