Sign upLogin

TianLiangZhou/shrimp-wechat-sdk

View on GitHub
Star
src/Api/Material.php

Summary

Maintainability
C
1 day
Test Coverage

File Material.php has 284 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Shrimp\Api;
Severity: Minor
Found in src/Api/Material.php - About 2 hrs to fix

    Function uploadFileChecked has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        private function uploadFileChecked(MediaFile $files, $type = null)
    {
        /**
         * @var File $file
         */
    Severity: Minor
    Found in src/Api/Material.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function add(MediaFile $files, $type = null, array $parameters = [])
    {
        try {
            list($file, $type) = $this->uploadFileChecked($files, $type);
        } catch (Exception $e) {
    Severity: Minor
    Found in src/Api/Material.php - About 1 hr to fix

      Method mediaUploadImg has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function mediaUploadImg(MediaFile $files)
    {
        $response = [];
        foreach ($files as $file) {
            $ext = $file->getExtName();
      Severity: Minor
      Found in src/Api/Material.php - About 1 hr to fix

        Method uploadFileChecked has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function uploadFileChecked(MediaFile $files, $type = null)
    {
        /**
         * @var File $file
         */
        Severity: Minor
        Found in src/Api/Material.php - About 1 hr to fix

          Function mediaUploadImg has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function mediaUploadImg(MediaFile $files)
    {
        $response = [];
        foreach ($files as $file) {
            $ext = $file->getExtName();
          Severity: Minor
          Found in src/Api/Material.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Consider simplifying this complex logical expression.
          Open

                  if (empty($article['title']) ||
            empty($article['content']) ||
            empty($article['content_source_url']) ||
            empty($article['thumb_media_id']) ||
            empty($article['author']) ||
          Severity: Major
          Found in src/Api/Material.php - About 40 mins to fix

            There are no issues that match your filters.

            Category
            Status