Sign upLogin

Tibblist/better-fetch

View on GitHub
Star

Showing 12 of 14 total issues

Function get has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.get = function(url, options = defaultOptions, callback) {
  if (url === undefined) {
    return Promise.reject(new Error("Missing url parameter in get request"));
  }
  if (options.mock) {
Severity: Minor
Found in src/better-fetcher.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      parseResponseData(response, options).then(function(data) {
    networkMap.set(options.url, true);
    if (options.handleNetworkResponse instanceof Function)
      options.handleNetworkResponse(data);
    else callback(data); ///Implement object comparison?
    Severity: Minor
    Found in src/responseHandler.js and 1 other location - About 50 mins to fix
    src/responseHandler.js on lines 45..50

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      if (options.dataType.toLowerCase() === "none") {
    cacheMap.set(options.url, true);
    if (options.handleCachedResponse instanceof Function)
      options.handleCachedResponse(response);
    else callback(response); ///Implement object comparison?
    Severity: Minor
    Found in src/responseHandler.js and 1 other location - About 50 mins to fix
    src/responseHandler.js on lines 61..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function get has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.get = function(url, options = defaultOptions, callback) {
  if (url === undefined) {
    return Promise.reject(new Error("Missing url parameter in get request"));
  }
  if (options.mock) {
    Severity: Minor
    Found in src/better-fetcher.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

      if (
    type !== "arrayBuffer" &&
    type !== "blob" &&
    type !== "formData" &&
    type !== "json" &&
    Severity: Major
    Found in src/utils.js - About 40 mins to fix

      Function prepareData has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        data,
  options,
  type,
  defaultOptions,
  defaultHeaders
      Severity: Minor
      Found in src/utils.js - About 35 mins to fix

        Function resolveDataType has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.resolveDataType = function(response) {
  var type = response.headers.get("Content-Type");
  if (!type || !(type instanceof String)) {
    return "none";
  }
        Severity: Minor
        Found in src/utils.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

          if (type.includes("text/javascript")) return "text";
        Severity: Major
        Found in src/utils.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return "blob";
          Severity: Major
          Found in src/utils.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              if (type.includes("multipart/form-data")) return "formData";
            Severity: Major
            Found in src/utils.js - About 30 mins to fix

              Function verifyOptions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              function verifyOptions(options) {
  if (options.dataType && !checkValidType(options.dataType))
    throw new Error("Attempting to set invalid data type");
  if (options.timeout && isNaN(options.timeout))
    throw new Error("Timeout must be a number (in ms)");
              Severity: Minor
              Found in src/better-fetcher.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function handleResponse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              exports.handleResponse = function(response, validator) {
  if (!response) {
    return new Promise(function(resolve, reject) {
      reject("No response");
    });
              Severity: Minor
              Found in src/responseHandler.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language