execute accesses the super-global variable $_ENV. Open
protected function execute(InputInterface $input, OutputInterface $output)
{
$currentCwd = getcwd();
$instancesOpt = $input->getOption('instances');
$excludesOpt = $input->getOption('exclude');
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Method execute
has 104 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function execute(InputInterface $input, OutputInterface $output)
{
$currentCwd = getcwd();
$instancesOpt = $input->getOption('instances');
$excludesOpt = $input->getOption('exclude');
Function execute
has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring. Open
protected function execute(InputInterface $input, OutputInterface $output)
{
$currentCwd = getcwd();
$instancesOpt = $input->getOption('instances');
$excludesOpt = $input->getOption('exclude');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method configure
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function configure()
{
parent::configure();
$this
The method execute() has an NPath complexity of 10800. The configured NPath complexity threshold is 200. Open
protected function execute(InputInterface $input, OutputInterface $output)
{
$currentCwd = getcwd();
$instancesOpt = $input->getOption('instances');
$excludesOpt = $input->getOption('exclude');
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method execute() has 130 lines of code. Current threshold is set to 100. Avoid really long methods. Open
protected function execute(InputInterface $input, OutputInterface $output)
{
$currentCwd = getcwd();
$instancesOpt = $input->getOption('instances');
$excludesOpt = $input->getOption('exclude');
- Exclude checks
The method execute() has a Cyclomatic Complexity of 17. The configured cyclomatic complexity threshold is 10. Open
protected function execute(InputInterface $input, OutputInterface $output)
{
$currentCwd = getcwd();
$instancesOpt = $input->getOption('instances');
$excludesOpt = $input->getOption('exclude');
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Missing class import via use statement (line '73', column '27'). Open
throw new \RuntimeException('Missing --file option required when using --push-to');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class '\TikiManager\Command\Helper\CommandHelper' in method 'getInstances'. Open
$instances = CommandHelper::validateInstanceSelection($instancesOpt, $instances);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method execute uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$this->io->writeln(sprintf(
'<info>Stats file %s uploaded to instance %s</info>',
$targetFile,
$toInstance->id
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\TikiManager\Command\Helper\CommandHelper' in method 'getInstances'. Open
$instances = CommandHelper::getInstances('all', true);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Possibly zero references to use statement for classlike/namespace App
(\TikiManager\Config\App)
Open
use TikiManager\Config\App;
- Exclude checks
Call to method getBestAccess
on non-class type ?mixed
Open
if (!$toInstance->getBestAccess('scripting')->fileExists($targetFile)) {
- Exclude checks
Call to method getBestAccess
on non-class type ?mixed
Open
$toInstance->getBestAccess('scripting')->uploadFile($tmpFile, $targetFile);
- Exclude checks