Sign upLogin

TikiWiki/tiki-manager

View on GitHub
Star
src/Command/UpgradeInstanceCommand.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method execute has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $checksumCheck = $input->getOption('check') ?? false;
        $instancesOption = $input->getOption('instances');
        $instances = CommandHelper::getInstances('update');
Severity: Major
Found in src/Command/UpgradeInstanceCommand.php - About 3 hrs to fix

    Method configure has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function configure()
    {
        parent::configure();

        $this
    Severity: Major
    Found in src/Command/UpgradeInstanceCommand.php - About 2 hrs to fix

      Function execute has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function execute(InputInterface $input, OutputInterface $output)
    {
        $checksumCheck = $input->getOption('check') ?? false;
        $instancesOption = $input->getOption('instances');
        $instances = CommandHelper::getInstances('update');
      Severity: Minor
      Found in src/Command/UpgradeInstanceCommand.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method execute() has 103 lines of code. Current threshold is set to 100. Avoid really long methods.
      Open

          protected function execute(InputInterface $input, OutputInterface $output)
    {
        $checksumCheck = $input->getOption('check') ?? false;
        $instancesOption = $input->getOption('instances');
        $instances = CommandHelper::getInstances('update');
      Severity: Minor
      Found in src/Command/UpgradeInstanceCommand.php by phpmd

      Avoid using static access to class '\TikiManager\Command\Helper\CommandHelper' in method 'execute'.
      Open

              $instancesInfo = CommandHelper::getInstancesInfo($instances);
      Severity: Minor
      Found in src/Command/UpgradeInstanceCommand.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\TikiManager\Command\Helper\CommandHelper' in method 'execute'.
      Open

                      CommandHelper::setInstanceSetupError($instance->id, $e);
      Severity: Minor
      Found in src/Command/UpgradeInstanceCommand.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\TikiManager\Command\Helper\CommandHelper' in method 'execute'.
      Open

              $instances = CommandHelper::getInstances('update');
      Severity: Minor
      Found in src/Command/UpgradeInstanceCommand.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\TikiManager\Command\Helper\CommandHelper' in method 'execute'.
      Open

                  CommandHelper::renderInstancesTable($output, $instancesInfo);
      Severity: Minor
      Found in src/Command/UpgradeInstanceCommand.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\TikiManager\Command\Helper\CommandHelper' in method 'execute'.
      Open

                  $phpVersion = CommandHelper::formatPhpVersion($instance->phpversion);
      Severity: Minor
      Found in src/Command/UpgradeInstanceCommand.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\TikiManager\Command\Helper\CommandHelper' in method 'execute'.
      Open

                          return CommandHelper::validateInstanceSelection($answer, $instances);
      Severity: Minor
      Found in src/Command/UpgradeInstanceCommand.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\TikiManager\Command\Helper\CommandHelper' in method 'execute'.
      Open

                  CommandHelper::validateInstanceSelection($instancesOption, $instances);
      Severity: Minor
      Found in src/Command/UpgradeInstanceCommand.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method execute uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            CommandHelper::validateInstanceSelection($instancesOption, $instances);
            $instancesOption = explode(',', $instancesOption);
            $selectedInstances = array_intersect_key($instances, array_flip($instancesOption));
        }
      Severity: Minor
      Found in src/Command/UpgradeInstanceCommand.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\TikiManager\Libs\Helpers\Checksum' in method 'execute'.
      Open

                          Checksum::handleCheckResult($instance, $version, $filesToResolve);
      Severity: Minor
      Found in src/Command/UpgradeInstanceCommand.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Possibly zero references to use statement for classlike/namespace Instance (\TikiManager\Application\Instance)
      Open

      use TikiManager\Application\Instance;
      Severity: Minor
      Found in src/Command/UpgradeInstanceCommand.php by phan

      There are no issues that match your filters.

      Category
      Status