Sign upLogin

TikiWiki/tiki-manager

View on GitHub
Star
src/Command/ViewDatabaseCommand.php

Summary

Maintainability
A
0 mins
Test Coverage

execute accesses the super-global variable $_ENV.
Open

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $databaseFile = $_ENV['DB_FILE'];

        $sqliteVersion = shell_exec(self::SQLITE.' --version');
Severity: Minor
Found in src/Command/ViewDatabaseCommand.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

The method execute uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $output->writeln('<error>' . self::SQLITE . ' is not available, please install and try again.</error>');
        }
Severity: Minor
Found in src/Command/ViewDatabaseCommand.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

There are no issues that match your filters.

Category
Status