src/Hooks/TikiCommandHook.php
execute accesses the super-global variable $_ENV. Open
Open
public function execute($type): void
{
$scripts = $this->getScripts($type);
if (empty($scripts)) {
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Avoid assigning values to variables in if clauses and the like (line '122', column '14'). Open
Open
protected function runScriptCommand(Process $process): bool
{
$this->logger->debug(
'Command {command}',
[
- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}