src/Libs/Host/FTP.php
The class FTP has 12 public methods. Consider refactoring FTP to keep number of public methods under 10. Open
Open
class FTP
{
private $host;
private $port;
private $user;- Read upRead up
- Exclude checks
TooManyPublicMethods
Since: 0.1
A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.
By default it ignores methods starting with 'get' or 'set'.
Example
Source https://phpmd.org/rules/codesize.html#toomanypublicmethods
The method fileExists uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$list = ftp_nlist($this->conn, "-a $dir");
return in_array($filename, $list) || in_array($base, $list);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
TODO found Open
Open
// TODO MAKE IT RECURSIVE- Exclude checks
Argument 2 (port) is string but \ftp_connect() takes int Open
Open
$conn = ftp_connect($this->host, $this->port, 15);- Exclude checks