Sign upLogin

TooAngel/screeps

View on GitHub
Star

Showing 594 of 594 total issues

File prototype_room_external.js has 610 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

const {getMyRoomWithinRange, findMyRoomsSortByDistance} = require('./helper_findMyRooms');
const {addToReputation, initPlayer, addRoomToPlayer} = require('./diplomacy');
const {haveActiveQuest} = require('./quests_player');
Severity: Major
Found in src/prototype_room_external.js - About 1 day to fix

    File prototype_room_my.js has 592 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

const {findMyRoomsSortByDistance} = require('./helper_findMyRooms');
const {addToReputation} = require('./diplomacy');
const {isFriend} = require('./brain_squadmanager');
    Severity: Major
    Found in src/prototype_room_my.js - About 1 day to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function setStatePrepareReactionLab1WithResource(creep) {
  const reaction = creep.room.memory.reaction;
  if (!reaction) {
    return false;
  }
      Severity: Major
      Found in src/role_mineral.js and 1 other location - About 1 day to fix
      src/role_mineral.js on lines 367..384

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 227.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function setStatePrepareReactionLab2WithResource(creep) {
  const reaction = creep.room.memory.reaction;
  if (!reaction) {
    return false;
  }
      Severity: Major
      Found in src/role_mineral.js and 1 other location - About 1 day to fix
      src/role_mineral.js on lines 341..358

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 227.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function exports has 232 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(grunt) {
  let account;
  try {
    account = require('./account.screeps.com'); // eslint-disable-line global-require
  } catch (e) {
      Severity: Major
      Found in Gruntfile.js - About 1 day to fix

        File prototype_creep_resources.js has 526 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        'use strict';

Creep.pickableResources = function(creep) {
  return (object) => creep.pos.isNearTo(object);
};
        Severity: Major
        Found in src/prototype_creep_resources.js - About 1 day to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          function getShards() {
  return new Promise((resolve) => {
    const options = {
      hostname: 'screeps.com',
      port: 443,
          Severity: Major
          Found in utils/respawner.js and 1 other location - About 1 day to fix
          utils/respawner.js on lines 8..32

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 201.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          function getWorldStatus() {
  return new Promise((resolve) => {
    const options = {
      hostname: 'screeps.com',
      port: 443,
          Severity: Major
          Found in utils/respawner.js and 1 other location - About 1 day to fix
          utils/respawner.js on lines 78..102

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 201.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              const req = https.request(options, (resp) => {
      console.log(`STATUS: ${resp.statusCode}`);
      console.log(`HEADERS: ${JSON.stringify(resp.headers)}`);
      let data = '';
          Severity: Major
          Found in utils/respawner.js and 1 other location - About 7 hrs to fix
          utils/respawner.js on lines 53..67

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 176.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              const req = https.request(options, (resp) => {
      console.log(`STATUS: ${resp.statusCode}`);
      console.log(`HEADERS: ${JSON.stringify(resp.headers)}`);
      let data = '';
          Severity: Major
          Found in utils/respawner.js and 1 other location - About 7 hrs to fix
          utils/respawner.js on lines 167..181

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 176.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          File prototype_room_creepbuilder.js has 447 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          'use strict';

const {
  CreepPartData,
  sortCreepParts,
          Severity: Minor
          Found in src/prototype_room_creepbuilder.js - About 6 hrs to fix

            File prototype_room_init.js has 441 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            'use strict';

// TODO this does not need to be on the Room object
Room.prototype.setPosition = function(type, pos, value = config.layout.structureAvoid, positionType = 'structure', firstStructure = false) {
  this.debugLog('baseBuilding', `Increasing ${pos} ${type} ${positionType} with ${value}`);
            Severity: Minor
            Found in src/prototype_room_init.js - About 6 hrs to fix

              Function action has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
              Open

              roles.atkeeper.action = function(creep) {
  // TODO Untested
  creep.spawnReplacement();
  creep.setNextSpawn();
  const center = new RoomPosition(25, 25, creep.memory.routing.targetRoom);
              Severity: Minor
              Found in src/role_atkeeper.js - About 5 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function action has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
              Open

              roles.atkeepermelee.action = function(creep) {
  // TODO Untested
  creep.spawnReplacement();
  creep.setNextSpawn();
  creep.memory.canHeal = creep.getActiveBodyparts(HEAL) > 0;
              Severity: Minor
              Found in src/role_atkeepermelee.js - About 5 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File prototype_creep.js has 372 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              'use strict';

const {addToReputation} = require('./diplomacy');

/**
              Severity: Minor
              Found in src/prototype_creep.js - About 4 hrs to fix

                Function setLabs has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
                Open

                Room.prototype.setLabs = function(allPaths) {
  let lab1Pos;
  let lab2Pos;
  let pathI;
  let path;
                Severity: Minor
                Found in src/prototype_room_init.js - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function checkBlockedPath has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
                Open

                Room.prototype.checkBlockedPath = function() {
  for (const pathName of Object.keys(this.getMemoryPaths())) {
    const path = this.getMemoryPath(pathName) || {};
    for (const pos of path) {
      const roomPos = new RoomPosition(pos.x, pos.y, this.name);
                Severity: Minor
                Found in src/prototype_room_external.js - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                File prototype_room_basebuilder.js has 352 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                'use strict';

/**
 * posIsIn position is in array
 *
                Severity: Minor
                Found in src/prototype_room_basebuilder.js - About 4 hrs to fix

                  Function showSearch has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
                  Open

                    showSearch(search) {
    if (search) {
      const rv = {};
      const getRV = (pos) => {
        if (!rv[pos.roomName]) {
                  Severity: Minor
                  Found in src/visualizer.js - About 4 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  Creep.prototype.withdrawRuin = function(onlyEnergy) {
  onlyEnergy = onlyEnergy || false;
  let returnValue = false;
  // FIND_RUINS and get them empty first
  const ruins = this.pos.findInRange(FIND_RUINS, 1);
                  Severity: Major
                  Found in src/prototype_creep_resources.js and 1 other location - About 4 hrs to fix
                  src/prototype_creep_resources.js on lines 127..140

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 123.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language