Sign upLogin

TooAngel/screeps

View on GitHub
Star
src/prototype_creep_clean.js

Summary

Maintainability
C
1 day
Test Coverage

Function cleanSetTargetId has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

Creep.prototype.cleanSetTargetId = function() {
  if (!this.room.isMy()) {
    //    this.log('no targetId');
    if (this.cleanController()) {
      //      this.log('clean controller');
Severity: Minor
Found in src/prototype_creep_clean.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handleStructurer has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Creep.prototype.handleStructurer = function() {
  if (!this.memory.routing.targetId) {
    return this.cleanSetTargetId();
  }
Severity: Minor
Found in src/prototype_creep_clean.js - About 1 hr to fix

    Function cleanSetTargetId has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Creep.prototype.cleanSetTargetId = function() {
  if (!this.room.isMy()) {
    //    this.log('no targetId');
    if (this.cleanController()) {
      //      this.log('clean controller');
    Severity: Minor
    Found in src/prototype_creep_clean.js - About 1 hr to fix

      Function cleanExits has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      Creep.prototype.cleanExits = function() {
  const exitDirs = [FIND_EXIT_TOP,
    FIND_EXIT_RIGHT,
    FIND_EXIT_BOTTOM,
    FIND_EXIT_LEFT,
      Severity: Minor
      Found in src/prototype_creep_clean.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function cleanExits has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Creep.prototype.cleanExits = function() {
  const exitDirs = [FIND_EXIT_TOP,
    FIND_EXIT_RIGHT,
    FIND_EXIT_BOTTOM,
    FIND_EXIT_LEFT,
      Severity: Minor
      Found in src/prototype_creep_clean.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                  if (structure.structureType === STRUCTURE_RAMPART) {
            structure = structureLook;
            break;
          }
        Severity: Major
        Found in src/prototype_creep_clean.js - About 45 mins to fix

          Function handleStructurer has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          Creep.prototype.handleStructurer = function() {
  if (!this.memory.routing.targetId) {
    return this.cleanSetTargetId();
  }
          Severity: Minor
          Found in src/prototype_creep_clean.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status